Re: [Outreachy kernel] [PATCH 0/2] Use #include <linux/uaccess.h> instead of <asm/uaccess.h>

[Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>]

On Fri, Feb 20, 2015 at 01:18:16PM +0530, Preeti U Murthy wrote:
> Hi Aya,
> 
> On 02/20/2015 07:13 AM, Aya Mahfouz wrote:
> > This patchset replaces <asm/uaccess.h> by <linux/uaccess.h>. The
> > replacements is safe since the header file <linux/uaccess.h> includes
> > <asm/uaccess.h>
> 
> Like Julia mentioned its a thoughtful comment. Such explanations are
> encouraged. However, it will be more valuable to include the above
> explanation in the changelogs of the patches also since those go into
> the git log of the kernel. The cover letter contains an overview of the
> patchset to help the reviewers. They do not get documented in the
> history of changes to the kernel. Would you therefore be able to resend
> this as a fresh version including the above lines in the changelog of
> the individual patches?
> 
> Regards
> Preeti U Murthy

Thank you Julia and Preeti for your comments. I will not send a new
version of this patch since the driver will be out of staging as Julia
stated in another thread. However, I will keep your advice in mind for
future patches.

Kind Regards,
Aya Saif El-yazal Mahfouz

> > 
> > Aya Mahfouz (2):
> >   staging: i2o: Use #include <linux/uaccess.h> instead of
> >     <asm/uaccess.h>
> >   staging: i2o: Use #include <linux/uaccess.h> instead of
> >     <asm/uaccess.h>
> > 
> >  drivers/staging/i2o/i2o_config.c | 3 +--
> >  drivers/staging/i2o/i2o_proc.c   | 2 +-
> >  2 files changed, 2 insertions(+), 3 deletions(-)
> > 
>