From: Florian Westphal <fw@strlen.de>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Florian Westphal <fw@strlen.de>,
Tomas Szepe <szepe@pinerecords.com>,
Francois Romieu <romieu@fr.zoreil.com>,
Hayes Wang <hayeswang@realtek.com>,
Eric Dumazet <edumazet@google.com>,
Tom Herbert <therbert@google.com>,
"David S. Miller" <davem@davemloft.net>,
Marco Berizzi <pupilla@hotmail.com>,
linux-kernel@vger.kernel.org, netdev <netdev@vger.kernel.org>
Subject: Re: 1e918876 breaks r8169 (linux-3.18+)
Date: Sat, 21 Feb 2015 18:46:25 +0100 [thread overview]
Message-ID: <20150221174625.GA29681@breakpoint.cc> (raw)
In-Reply-To: <1424535746.5565.42.camel@edumazet-glaptop2.roam.corp.google.com>
Eric Dumazet <eric.dumazet@gmail.com> wrote:
> Hold on.
>
> I believe there is one race in the way you access skb->xmit_more _after_
>
> txd->opts1 = cpu_to_le32(status);
>
> After this point, TX might have completed and TX completion already have
> freed skb
Hmm, I _thought_ HW would not start xmit of this descriptor/skb until after
RTL_W8(TxPoll, NPQ);
call a bit later... your patch surely looks safer though, thanks for
looking into this.
> Could Tomas try following fix ?
In addition -- Tomas, on your affected board -- did you try
turning off gso/tso?
Holger Hoffstätte mentioned on lkml that his affected r8169 nic is
stable with xmit_more+bql after disabling gso/tso on the nic
(ethtool -k $dev to display settings, "-K $dev tso off gso off" to
disable offloads).
next prev parent reply other threads:[~2015-02-21 17:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-03 10:08 1e918876 breaks r8169 (linux-3.18+) Tomas Szepe
2015-02-03 10:42 ` Florian Westphal
2015-02-05 16:56 ` Tomáš Szépe
2015-02-06 14:04 ` Tomas Szepe
2015-02-08 12:18 ` Holger Hoffstätte
2015-02-10 15:45 ` Florian Westphal
2015-02-11 9:46 ` Tomáš Szépe
2015-02-21 10:15 ` Tomas Szepe
2015-02-21 10:31 ` Florian Westphal
2015-02-21 10:57 ` Holger Hoffstätte
2015-02-21 16:22 ` Eric Dumazet
2015-02-21 17:46 ` Florian Westphal [this message]
2015-02-21 18:09 ` Eric Dumazet
2015-02-21 18:32 ` Florian Westphal
2015-02-21 19:26 ` Tomas Szepe
2015-02-21 19:05 ` Tomas Szepe
2015-02-21 19:54 ` Eric Dumazet
2015-02-22 0:41 ` Tomas Szepe
2015-02-22 20:57 ` David Miller
[not found] <E1YqR6a-0007T7-Dz@feisty.vs19.net>
2015-05-07 19:22 ` Daniel Exner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150221174625.GA29681@breakpoint.cc \
--to=fw@strlen.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=hayeswang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pupilla@hotmail.com \
--cc=romieu@fr.zoreil.com \
--cc=szepe@pinerecords.com \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.