Re: [Qemu-devel] [PATCH v3 0/3] -incoming defer

["Dr. David Alan Gilbert" <dgilbert@redhat.com>]

* Stefan Hajnoczi (stefanha@gmail.com) wrote:
> On Thu, Feb 19, 2015 at 11:40:26AM +0000, Dr. David Alan Gilbert (git) wrote:
> > From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> > 
> > This patchset provides a way of setting options on an incoming
> > migration before the fd/process/socket has been created.
> > 
> >    start qemu with   -incoming defer
> >    <use the monitor to set whatever you need>
> >    migrate_incoming theuri
> 
> Does this patch series break BDRV_O_INCOMING?
> 
> blockdev.c:blockdev_init():
>   if (runstate_check(RUN_STATE_INMIGRATE)) {
>       bdrv_flags |= BDRV_O_INCOMING;
>   }
> 
> The block layer needs to know about incoming migrations to avoid
> accessing or caching disk images while the source host still has them
> open.

No, it doesn't break it; it goes into RUN_STATE_INMIGRATE at startup
in the same way that all existing -incoming's do; the state transitions
should be identical.

Dave

> 
> Stefan


--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK