From: Vinod Koul <vinod.koul@intel.com>
To: Qiao Zhou <zhouqiao@marvell.com>
Cc: zhangfei.gao@linaro.org, dan.j.williams@intel.com,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dma: mmp-tdma: refine dma disable and dma-pos update
Date: Mon, 23 Feb 2015 16:53:01 +0530 [thread overview]
Message-ID: <20150223112301.GB5208@intel.com> (raw)
In-Reply-To: <1423140859-20074-1-git-send-email-zhouqiao@marvell.com>
On Thu, Feb 05, 2015 at 08:54:19PM +0800, Qiao Zhou wrote:
> Below are the refinements.
> 1. Set DMA abort bit when disabling dma channel. This will clear
> the remaining data in dma FIFO, to fix channel-swap issue.
> 2. Read DMA HW pointer when updating DMA status. Previously dma
> position is calculated by adding one period size in dma interrupt.
> This is inaccurate/insufficient for some high-quality audio APP.
> Since interrupt bottom half handler has variable schedule delay,
> it causes big error when calculating sample delay. Read the actual
> HW pointer and feedback can improve the accuracy.
> 3. Do some minor code clean.
This fails to apply for me, care to rebase pls
--
~Vinod
next prev parent reply other threads:[~2015-02-23 11:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-05 12:54 [PATCH] dma: mmp-tdma: refine dma disable and dma-pos update Qiao Zhou
2015-02-06 5:19 ` Zhangfei Gao
2015-02-23 11:23 ` Vinod Koul [this message]
2015-02-28 9:39 ` Qiao Zhou
2015-03-02 16:56 ` Vinod Koul
2015-03-03 1:20 ` Qiao Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150223112301.GB5208@intel.com \
--to=vinod.koul@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zhangfei.gao@linaro.org \
--cc=zhouqiao@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.