From: Lee Jones <lee@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, Stephen Boyd <sboyd@codeaurora.org>,
Mike Turquette <mturquette@linaro.org>,
Bryan Huntsman <bryanh@codeaurora.org>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Ralf Baechle <ralf@linux-mips.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
Tomeu Vizoso <tomeu.vizoso@collabora.com>
Subject: Re: [PATCH v2 1/1] clkdev: change prototype of clk_register_clkdev()
Date: Mon, 23 Feb 2015 11:53:56 +0000 [thread overview]
Message-ID: <20150223115356.GA21609@x1> (raw)
In-Reply-To: <1424692181-14455-2-git-send-email-andriy.shevchenko@linux.intel.com>
On Mon, 23 Feb 2015, Andy Shevchenko wrote:
> Since clk_register_clkdev() is exported for modules the caller should get a
> pointer to the allocated resources. Otherwise the memory leak is guaranteed on
> the ->remove() stage.
>
> Cc: Tomeu Vizoso <tomeu.vizoso@collabora.com>
> Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> arch/arm/mach-msm/clock-pcom.c | 9 +++++----
> arch/arm/mach-vexpress/spc.c | 5 ++++-
> arch/mips/ath79/clock.c | 6 +++---
> drivers/clk/clk-bcm2835.c | 12 +++++++-----
> drivers/clk/clk-max-gen.c | 9 ++++-----
> drivers/clk/clk-xgene.c | 6 +++---
> drivers/clk/clkdev.c | 15 ++++++++++-----
> drivers/clk/samsung/clk-pll.c | 13 ++++++++-----
> drivers/clk/samsung/clk-s3c2410-dclk.c | 19 +++++++++---------
> drivers/clk/samsung/clk.c | 35 +++++++++++++++++++---------------
> include/linux/clkdev.h | 2 +-
> 11 files changed, 75 insertions(+), 56 deletions(-)
What's tying all of these changes together? It would be better
(simpler for you) if you split them up by subsystem and resubmitted.
next prev parent reply other threads:[~2015-02-23 11:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-23 11:49 [PATCH v2 0/1] clkdev: prevent potential memory leak when used in modules Andy Shevchenko
2015-02-23 11:49 ` [PATCH v2 1/1] clkdev: change prototype of clk_register_clkdev() Andy Shevchenko
2015-02-23 11:53 ` Lee Jones [this message]
2015-02-23 11:57 ` Andy Shevchenko
2015-02-23 12:02 ` Andy Shevchenko
2015-02-23 12:03 ` Russell King - ARM Linux
2015-02-23 12:23 ` Lee Jones
2015-02-23 12:36 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150223115356.GA21609@x1 \
--to=lee@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bryanh@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=lorenzo.pieralisi@arm.com \
--cc=mturquette@linaro.org \
--cc=ralf@linux-mips.org \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@codeaurora.org \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.