From: Peter Zijlstra <peterz@infradead.org>
To: Aleksa Sarai <cyphar@cyphar.com>
Cc: tj@kernel.org, lizefan@huawei.com, mingo@redhat.com,
richard@nod.at, fweisbec@gmail.com, linux-kernel@vger.kernel.org,
cgroups@vger.kernel.org
Subject: Re: [PATCH RFC 1/2] cgroups: allow a cgroup subsystem to reject a fork
Date: Mon, 23 Feb 2015 15:49:07 +0100 [thread overview]
Message-ID: <20150223144907.GZ5029@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1424660891-12719-2-git-send-email-cyphar@cyphar.com>
On Mon, Feb 23, 2015 at 02:08:10PM +1100, Aleksa Sarai wrote:
> NOTE: I'm not sure if I'm doing enough cleanup inside copy_process(),
> because a bunch of stuff happens between the last valid goto to the
> bad_fork_free_pid label and cgroup_post_fork().
>
> What is the correct way of doing cleanup this late inside
> copy_process()?
Its not; you're past the point of fail. You've already exposed the new
process.
If you want to allow fail, you'll have to do it earlier.
next prev parent reply other threads:[~2015-02-23 14:49 UTC|newest]
Thread overview: 108+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-23 3:08 [PATCH RFC 0/2] add nproc cgroup subsystem Aleksa Sarai
2015-02-23 3:08 ` Aleksa Sarai
2015-02-23 3:08 ` [PATCH RFC 1/2] cgroups: allow a cgroup subsystem to reject a fork Aleksa Sarai
2015-02-23 14:49 ` Peter Zijlstra [this message]
2015-02-23 3:08 ` [PATCH RFC 2/2] cgroups: add an nproc subsystem Aleksa Sarai
[not found] ` <1424660891-12719-1-git-send-email-cyphar-gVpy/LI/lHzQT0dZR+AlfA@public.gmane.org>
2015-02-27 4:17 ` [RFC PATCH v2 0/2] add nproc cgroup subsystem Aleksa Sarai
2015-02-27 4:17 ` Aleksa Sarai
[not found] ` <1425010639-16492-1-git-send-email-cyphar-gVpy/LI/lHzQT0dZR+AlfA@public.gmane.org>
2015-02-27 4:17 ` [PATCH v2 1/2] cgroups: allow a cgroup subsystem to reject a fork Aleksa Sarai
2015-02-27 4:17 ` Aleksa Sarai
[not found] ` <1425010639-16492-2-git-send-email-cyphar-gVpy/LI/lHzQT0dZR+AlfA@public.gmane.org>
2015-03-09 3:06 ` Tejun Heo
2015-03-09 3:06 ` Tejun Heo
[not found] ` <CAOviyaip7Faz98YWzGoTaXGYVb72sfD+ZL4Xa89reU9+=43jFA@mail.gmail.com>
[not found] ` <20150309065902.GP13283@htj.duckdns.org>
[not found] ` <20150309065902.GP13283-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2015-03-10 8:19 ` Aleksa Sarai
2015-03-10 8:19 ` Aleksa Sarai
[not found] ` <CAOviyaj3mf66ho15WrD8qB=ECxKWYTAkWodxWaFVMWeZG4d0FQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-03-10 12:47 ` Tejun Heo
2015-03-10 12:47 ` Tejun Heo
[not found] ` <20150310124701.GB28730-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2015-03-10 14:51 ` Aleksa Sarai
2015-03-10 14:51 ` Aleksa Sarai
[not found] ` <CAOviyai7yJrbGb+uYpK35tw7R-KM0jWQ-BmhpyTqnRFJsVYdUA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-03-10 15:17 ` Tejun Heo
2015-03-10 15:17 ` Tejun Heo
2015-03-11 5:16 ` Aleksa Sarai
2015-03-11 11:46 ` Tejun Heo
2015-03-11 23:47 ` Aleksa Sarai
2015-03-11 23:47 ` Aleksa Sarai
[not found] ` <CAOviyaj55Yqahz75Gy5=yjFteeKFp7746=80-Ufww2E62Ads_Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-03-12 1:25 ` Tejun Heo
2015-03-12 1:25 ` Tejun Heo
2015-02-27 4:17 ` [PATCH v2 2/2] cgroups: add an nproc subsystem Aleksa Sarai
[not found] ` <1425010639-16492-3-git-send-email-cyphar-gVpy/LI/lHzQT0dZR+AlfA@public.gmane.org>
2015-03-02 15:22 ` Tejun Heo
2015-03-02 15:22 ` Tejun Heo
[not found] ` <20150302152205.GC17694-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2015-03-09 1:49 ` Zefan Li
2015-03-09 1:49 ` Zefan Li
[not found] ` <54FCFC39.6050900-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2015-03-09 2:34 ` Tejun Heo
2015-03-09 2:34 ` Tejun Heo
2015-03-06 1:45 ` [PATCH v4 0/2] cgroup: add pids subsystem Aleksa Sarai
2015-03-06 1:45 ` Aleksa Sarai
2015-03-06 1:45 ` [PATCH v4 1/2] cgroups: allow a cgroup subsystem to reject a fork Aleksa Sarai
[not found] ` <1425606357-6337-1-git-send-email-cyphar-gVpy/LI/lHzQT0dZR+AlfA@public.gmane.org>
2015-03-06 1:45 ` [PATCH v4 2/2] cgroups: add a pids subsystem Aleksa Sarai
2015-03-06 1:45 ` Aleksa Sarai
[not found] ` <1425606357-6337-3-git-send-email-cyphar-gVpy/LI/lHzQT0dZR+AlfA@public.gmane.org>
2015-03-09 3:34 ` Tejun Heo
2015-03-09 3:34 ` Tejun Heo
[not found] ` <20150309033405.GE13283-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2015-03-09 3:39 ` Tejun Heo
2015-03-09 3:39 ` Tejun Heo
2015-03-09 18:58 ` Austin S Hemmelgarn
2015-03-09 18:58 ` Austin S Hemmelgarn
[not found] ` <54FDED43.4050908-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-03-09 19:51 ` Tejun Heo
2015-03-09 19:51 ` Tejun Heo
2015-03-10 8:10 ` Aleksa Sarai
2015-03-10 8:10 ` Aleksa Sarai
2015-03-10 11:32 ` Austin S Hemmelgarn
[not found] ` <54FED651.6040100-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-03-10 12:31 ` Aleksa Sarai
2015-03-10 12:31 ` Aleksa Sarai
[not found] ` <CAOviyagpCNcAN4hdhsxffdpE+yDmw+NXx+FikTe64GJ1hQeXhQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-03-11 15:13 ` Austin S Hemmelgarn
2015-03-11 15:13 ` Austin S Hemmelgarn
[not found] ` <55005BAC.9060405-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-03-12 2:28 ` Aleksa Sarai
2015-03-12 2:28 ` Aleksa Sarai
2015-03-12 15:35 ` Austin S Hemmelgarn
2015-03-12 3:47 ` Tejun Heo
2015-03-09 3:08 ` [PATCH v4 0/2] cgroup: add " Tejun Heo
2015-03-09 3:08 ` Tejun Heo
2015-02-27 11:49 ` [PATCH RFC 0/2] add nproc cgroup subsystem Tejun Heo
[not found] ` <20150227114940.GB3964-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2015-02-27 13:46 ` Richard Weinberger
2015-02-27 13:46 ` Richard Weinberger
[not found] ` <54F07525.4050100-/L3Ra7n9ekc@public.gmane.org>
2015-02-27 13:52 ` Tejun Heo
2015-02-27 13:52 ` Tejun Heo
2015-02-27 16:42 ` Austin S Hemmelgarn
2015-02-27 16:42 ` Austin S Hemmelgarn
[not found] ` <54F09E62.8000007-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-02-27 17:06 ` Tejun Heo
2015-02-27 17:06 ` Tejun Heo
[not found] ` <20150227170640.GK3964-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2015-02-27 17:25 ` Tim Hockin
2015-02-27 17:25 ` Tim Hockin
2015-02-27 17:45 ` Tejun Heo
[not found] ` <20150227174503.GM3964-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2015-02-27 17:56 ` Tejun Heo
2015-02-27 17:56 ` Tejun Heo
2015-02-27 21:45 ` Tim Hockin
2015-02-27 21:45 ` Tim Hockin
2015-02-27 21:49 ` Tejun Heo
[not found] ` <CAAAKZwsCc8BtFx58KMFpRTohU81oCBeGVOPGMJrjJt9q5upKfQ@mail.gmail.com>
2015-02-28 16:57 ` Tejun Heo
[not found] ` <20150228165706.GS3964-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2015-02-28 22:26 ` Tim Hockin
2015-02-28 22:26 ` Tim Hockin
[not found] ` <CAAAKZwv=idxvrffHx2QyW=PGH4k42ckq-VLJGQrXkeQ6NmByRQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-02-28 22:50 ` Tejun Heo
2015-02-28 22:50 ` Tejun Heo
[not found] ` <20150228225036.GA4597-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2015-03-01 4:46 ` Tim Hockin
2015-03-01 4:46 ` Tim Hockin
2015-02-28 23:11 ` Johannes Weiner
2015-02-28 23:11 ` Johannes Weiner
2015-02-27 18:49 ` Austin S Hemmelgarn
2015-02-27 18:49 ` Austin S Hemmelgarn
[not found] ` <54F0BC51.4050506-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-02-27 19:35 ` Tejun Heo
2015-02-27 19:35 ` Tejun Heo
2015-02-28 9:26 ` Aleksa Sarai
2015-02-28 9:26 ` Aleksa Sarai
[not found] ` <CAOviyajSOY6kTiwTA+APf9VGT=Ui=0QQH6KUqwaxHB3ahuJk2g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-02-28 11:59 ` Tejun Heo
2015-02-28 11:59 ` Tejun Heo
[not found] ` <CAAAKZws45c3PhFQMGrm_K+OZV+KOyGV9sXTakHcTfNP1kHxzOQ@mail.gmail.com>
[not found] ` <CAAAKZws45c3PhFQMGrm_K+OZV+KOyGV9sXTakHcTfNP1kHxzOQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-02-28 16:43 ` Tejun Heo
2015-02-28 16:43 ` Tejun Heo
2015-03-02 13:13 ` Austin S Hemmelgarn
[not found] ` <54F461F3.3030903-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-03-02 13:31 ` Aleksa Sarai
2015-03-02 13:31 ` Aleksa Sarai
[not found] ` <CAOviyahKJthwLTND51HhaRNB_KJC60T7HFHjdqPZf3pQmAUAhw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-03-02 13:54 ` Tejun Heo
2015-03-02 13:54 ` Tejun Heo
2015-03-02 13:49 ` Tejun Heo
2015-02-27 17:12 ` Tim Hockin
[not found] ` <CAO_RewbeTbMuqVG5wsui_gHwrdgqjF0KLk6yr5a3bb76VOkofg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-02-27 17:15 ` Tejun Heo
2015-02-27 17:15 ` Tejun Heo
2015-03-04 20:23 ` [PATCH v3 0/2] cgroup: add pids subsystem Aleksa Sarai
2015-03-04 20:23 ` [PATCH v3 1/2] cgroups: allow a cgroup subsystem to reject a fork Aleksa Sarai
2015-03-04 20:23 ` [PATCH v3 2/2] cgroups: add a pids subsystem Aleksa Sarai
2015-03-05 8:39 ` Aleksa Sarai
2015-03-05 14:37 ` Marian Marinov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150223144907.GZ5029@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=cgroups@vger.kernel.org \
--cc=cyphar@cyphar.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=mingo@redhat.com \
--cc=richard@nod.at \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.