From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38490) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YPzLP-0002LU-Lw for qemu-devel@nongnu.org; Mon, 23 Feb 2015 15:11:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YPzLH-0001DJ-F2 for qemu-devel@nongnu.org; Mon, 23 Feb 2015 15:11:07 -0500 Received: from mx1.redhat.com ([209.132.183.28]:58994) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YPzLH-0001DB-82 for qemu-devel@nongnu.org; Mon, 23 Feb 2015 15:10:59 -0500 Date: Mon, 23 Feb 2015 17:10:28 -0300 From: Eduardo Habkost Message-ID: <20150223201028.GD31950@thinpad.lan.raisama.net> References: <1423763435-3696-1-git-send-email-ehabkost@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1423763435-3696-1-git-send-email-ehabkost@redhat.com> Subject: Re: [Qemu-devel] [PATCH v3 0/4] NUMA: Validate CPU configuration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Paolo Bonzini , "Michael S. Tsirkin" , Hu Tao , Igor Mammedov Ping? Can somebody help review this? On Thu, Feb 12, 2015 at 03:50:31PM -0200, Eduardo Habkost wrote: > This adds extra checks to the NUMA code to make sure the CPU configuration is > consistent. This needs to be applied on top of the following series: > > Message-Id: <1423421482-11619-1-git-send-email-ehabkost@redhat.com> > Subject: [Qemu-devel] [PATCH 0/7] NUMA code cleanup > From: Eduardo Habkost > Date: Sun, 8 Feb 2015 16:51:15 -0200 > Git tree: https://github.com/ehabkost/qemu.git numa-next > > Changes v1 -> v2: > * (none, v1 was tagged by accident and never sent to qemu-devel) > > Changes v2 -> v3: > * Fix off-by-one error on CPU index check > * Use GString and error_report() instead of calling fprintf() directly > * Simplify logic of the CPUs-not-present check > > Eduardo Habkost (4): > numa: Fix off-by-one error at MAX_CPUMASK_BITS check > numa: Reject CPU indexes > max_cpus > numa: Reject configuration if CPU appears on multiple nodes > numa: Print warning if no node is assigned to a CPU > > numa.c | 53 ++++++++++++++++++++++++++++++++++++++++++++++++++--- > 1 file changed, 50 insertions(+), 3 deletions(-) > > -- > 2.1.0 > > -- Eduardo