From: Dave Chinner <david@fromorbit.com>
To: Omar Sandoval <osandov@osandov.com>
Cc: fstests@vger.kernel.org, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: add regression tests for ^extents punch hole
Date: Tue, 24 Feb 2015 09:46:20 +1100 [thread overview]
Message-ID: <20150223224620.GL12722@dastard> (raw)
In-Reply-To: <4c557308eb4e62752dc8b513495cb6d46ca5775d.1424730653.git.osandov@osandov.com>
On Mon, Feb 23, 2015 at 02:39:36PM -0800, Omar Sandoval wrote:
> Linux commit 6f30b7e37a82 (ext4: fix indirect punch hole corruption)
> fixes several bugs in the FALLOC_FL_PUNCH_HOLE implementation for an
> ext4 filesystem with indirect blocks.
>
> Signed-off-by: Omar Sandoval <osandov@osandov.com>
> ---
> tests/ext4/005 | 115 +++++++++++++++++++++++++++++++++++++++++++++++++++++
> tests/ext4/005.out | 29 ++++++++++++++
> tests/ext4/group | 1 +
> 3 files changed, 145 insertions(+)
> create mode 100755 tests/ext4/005
> create mode 100644 tests/ext4/005.out
What's ext4 specific about this test apart from the mkfs parameter?
Shouldn't it be generic and so test all the filesystems behave the
same? i.e. when someone then runs
# MKFS_OPTIONS="-b size=1k -O ^extents" ./check -g auto
That will exercise this specific regression fix, not to mention give
much, much better test coverage of that configuration than just
making a single test use that config...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2015-02-23 22:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-23 22:39 [PATCH] ext4: add regression tests for ^extents punch hole Omar Sandoval
2015-02-23 22:46 ` Dave Chinner [this message]
2015-02-23 23:11 ` Omar Sandoval
2015-02-23 23:28 ` Eric Sandeen
2015-02-23 23:43 ` Eric Sandeen
2015-02-24 10:11 ` Lukáš Czerner
2015-02-24 11:31 ` Dave Chinner
2015-02-24 11:52 ` Lukáš Czerner
2015-02-24 12:49 ` Dave Chinner
2015-02-24 14:58 ` Lukáš Czerner
2015-02-24 22:07 ` Dave Chinner
2015-02-25 0:24 ` Theodore Ts'o
2015-02-25 3:03 ` Omar Sandoval
2015-02-25 8:42 ` Lukáš Czerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150223224620.GL12722@dastard \
--to=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=osandov@osandov.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.