From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from kirsty.vergenet.net ([202.4.237.240]:51680 "EHLO kirsty.vergenet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751848AbbBXB5N (ORCPT ); Mon, 23 Feb 2015 20:57:13 -0500 Date: Tue, 24 Feb 2015 10:57:07 +0900 From: Simon Horman To: Nobuhiro Iwamatsu Cc: bhelgaas@google.com, linux-pci@vger.kernel.org, phil.edworthy@renesas.com Subject: Re: [PATCH] PCI: rcar: Fix postion of MSI enable bit Message-ID: <20150224015707.GA10297@verge.net.au> References: <1422853779-14413-1-git-send-email-nobuhiro.iwamatsu.yj@renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1422853779-14413-1-git-send-email-nobuhiro.iwamatsu.yj@renesas.com> Sender: linux-pci-owner@vger.kernel.org List-ID: On Mon, Feb 02, 2015 at 02:09:39PM +0900, Nobuhiro Iwamatsu wrote: > Position of MSI enable bit is 31bit, not 28bit. > This fixes position of MSI bit necessary to initialize MSI. > > Signed-off-by: Nobuhiro Iwamatsu Acked-by: Simon Horman > --- > drivers/pci/host/pcie-rcar.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/host/pcie-rcar.c b/drivers/pci/host/pcie-rcar.c > index bb36e27..eb12659 100644 > --- a/drivers/pci/host/pcie-rcar.c > +++ b/drivers/pci/host/pcie-rcar.c > @@ -505,7 +505,7 @@ static int rcar_pcie_hw_init(struct rcar_pcie *pcie) > > /* Enable MSI */ > if (IS_ENABLED(CONFIG_PCI_MSI)) > - rcar_pci_write_reg(pcie, 0x101f0000, PCIEMSITXR); > + rcar_pci_write_reg(pcie, 0x801f0000, PCIEMSITXR); > > /* Finish initialization - establish a PCI Express link */ > rcar_pci_write_reg(pcie, CFINIT, PCIETCTLR); > -- > 2.1.3 >