From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45963) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQBRQ-0001mD-CS for qemu-devel@nongnu.org; Tue, 24 Feb 2015 04:06:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YQBRL-00068W-Tm for qemu-devel@nongnu.org; Tue, 24 Feb 2015 04:06:08 -0500 Date: Tue, 24 Feb 2015 19:55:32 +1100 From: David Gibson Message-ID: <20150224085532.GS4536@voom.redhat.com> References: <1424732702-23443-1-git-send-email-david@gibson.dropbear.id.au> <1424732702-23443-2-git-send-email-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="uNvczuo8OWfsyO2w" Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH 1/3] Add specific config options for PCI-E bridges List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite Cc: "qemu-devel@nongnu.org Developers" , Paolo Bonzini , qemu-ppc Mailing List , Alexander Graf , "Michael S. Tsirkin" --uNvczuo8OWfsyO2w Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 23, 2015 at 10:17:58PM -0800, Peter Crosthwaite wrote: > On Mon, Feb 23, 2015 at 3:05 PM, David Gibson > wrote: > > The i82801b11, ioh3420 and xio3130 PCI Express devices are currently > > included in the build unconditionally. > > > > While they could theoretically appear on any target platform with PCI-E, > > they're pretty unlikely to appear on platforms that aren't Intel derive= d. > > > > Therefore, to avoid presenting unlikely-to-be-relevant devices to the u= ser, > > add config options to enable these componenets, and enable they by defa= ult >=20 > "components", "them" Oops, those are embarrassing. > > only on x86 and arm platforms. > > > > (Note that this patch does include these for aarch64, via its inclusion= of > > arm-softmmu.mak). > > >=20 > "it's" No, "its" is correct. It's a possessive, not a contraction. > > Signed-off-by: David Gibson >=20 > Otherwise, >=20 > Reviewed-by: Peter Crosthwaite >=20 > > --- > > default-configs/arm-softmmu.mak | 4 ++++ > > default-configs/i386-softmmu.mak | 3 +++ > > default-configs/x86_64-softmmu.mak | 3 +++ > > hw/pci-bridge/Makefile.objs | 5 +++-- > > 4 files changed, 13 insertions(+), 2 deletions(-) > > > > diff --git a/default-configs/arm-softmmu.mak b/default-configs/arm-soft= mmu.mak > > index b00c2e1..6ee9b43 100644 > > --- a/default-configs/arm-softmmu.mak > > +++ b/default-configs/arm-softmmu.mak > > @@ -91,3 +91,7 @@ CONFIG_INTEGRATOR_DEBUG=3Dy > > CONFIG_ALLWINNER_A10_PIT=3Dy > > CONFIG_ALLWINNER_A10_PIC=3Dy > > CONFIG_ALLWINNER_A10=3Dy > > + > > +CONFIG_XIO3130=3Dy > > +CONFIG_IOH3420=3Dy > > +CONFIG_I82801B11=3Dy > > diff --git a/default-configs/i386-softmmu.mak b/default-configs/i386-so= ftmmu.mak > > index bd99af9..0b8ce4b 100644 > > --- a/default-configs/i386-softmmu.mak > > +++ b/default-configs/i386-softmmu.mak > > @@ -43,3 +43,6 @@ CONFIG_IOAPIC=3Dy > > CONFIG_ICC_BUS=3Dy > > CONFIG_PVPANIC=3Dy > > CONFIG_MEM_HOTPLUG=3Dy > > +CONFIG_XIO3130=3Dy > > +CONFIG_IOH3420=3Dy > > +CONFIG_I82801B11=3Dy > > diff --git a/default-configs/x86_64-softmmu.mak b/default-configs/x86_6= 4-softmmu.mak > > index e7c2734..6add04a 100644 > > --- a/default-configs/x86_64-softmmu.mak > > +++ b/default-configs/x86_64-softmmu.mak > > @@ -43,3 +43,6 @@ CONFIG_IOAPIC=3Dy > > CONFIG_ICC_BUS=3Dy > > CONFIG_PVPANIC=3Dy > > CONFIG_MEM_HOTPLUG=3Dy > > +CONFIG_XIO3130=3Dy > > +CONFIG_IOH3420=3Dy > > +CONFIG_I82801B11=3Dy > > diff --git a/hw/pci-bridge/Makefile.objs b/hw/pci-bridge/Makefile.objs > > index 968b369..96c596e 100644 > > --- a/hw/pci-bridge/Makefile.objs > > +++ b/hw/pci-bridge/Makefile.objs > > @@ -1,5 +1,6 @@ > > common-obj-y +=3D pci_bridge_dev.o > > -common-obj-y +=3D ioh3420.o xio3130_upstream.o xio3130_downstream.o > > -common-obj-y +=3D i82801b11.o > > +common-obj-$(CONFIG_XIO3130) +=3D xio3130_upstream.o xio3130_downstrea= m.o > > +common-obj-$(CONFIG_IOH3420) +=3D ioh3420.o > > +common-obj-$(CONFIG_I82801B11) +=3D i82801b11.o > > # NewWorld PowerMac > > common-obj-$(CONFIG_DEC_PCI) +=3D dec.o > > > > >=20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --uNvczuo8OWfsyO2w Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJU7DyEAAoJEGw4ysog2bOSe74P/3OTyE55GJkfyPR8CY79QnYn +0MybgaWseg7YtxjKAdfcpyKrOHPhnT9pE6qZl19hmwj4ByiaLQGT6VegV2TDvBO pONfhlPv/QuYBzcwzp7WyYtsX3IxPaP7P+sOeiA3xZOpf5M1dPomxYEKYmbIdkTC 2P1LPQRH+l1+yu80IWuLlokgedO/zBFuc3e1BiekPrQC8IEAdczmQndvAr7Dj1cn oYlCoN7QW1kma5ncHLxM2KE8jCqSn4tTa3SKWUg8k6S1kbQ+iCHdwKAQDY/vfyGb DXtimGRWa+JSW3LfWq3MbMl+DB1arOSbng8ckPNNsV17NJrOdkHu26SfLJ473bQJ j627+sNh4h+ilzIAv8kJ84c0gToNCESyanEXxU0bmo3eOoLYYoAUhe5wtwO4erQU rGSBb/xVPgztsStfKbCW6bvAFNUMbz8d+RaIDTdCPl/L0/k/8TgUgb2e5DC3n9YC HJDBw3NoAWsxp2iTW9Y7TdVpd41WEUWxfsVIDQPra/ClN+IPlZoxUHHxsfjQqhhM YHM9uk0u/TxEWc/4SrOeM1Db0XwYeaWMEqCdGmEV/8ChPVkXZsrakrnHlFt6NkRp KQHs1Z0+IIDA4KgjZbiN47qzjZrr5tWw/6layNVUCyyBbS7I79GDCqmE0iUgaFbP X3NbEISwnn13O34XpG9j =ARqr -----END PGP SIGNATURE----- --uNvczuo8OWfsyO2w--