From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45946) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQBRP-0001mC-47 for qemu-devel@nongnu.org; Tue, 24 Feb 2015 04:06:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YQBRL-00068M-SA for qemu-devel@nongnu.org; Tue, 24 Feb 2015 04:06:07 -0500 Date: Tue, 24 Feb 2015 19:57:11 +1100 From: David Gibson Message-ID: <20150224085711.GT4536@voom.redhat.com> References: <1424732702-23443-1-git-send-email-david@gibson.dropbear.id.au> <1424732702-23443-4-git-send-email-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="HtRZva1Vzv8iP5ye" Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH 3/3] Give ivshmem its own config option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite Cc: "qemu-devel@nongnu.org Developers" , Paolo Bonzini , qemu-ppc Mailing List , Alexander Graf , "Michael S. Tsirkin" --HtRZva1Vzv8iP5ye Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 23, 2015 at 10:38:06PM -0800, Peter Crosthwaite wrote: > On Mon, Feb 23, 2015 at 3:05 PM, David Gibson > wrote: > > Currently the ivshmem device is built whenever both PCI and KVM support= are > > included. This patch gives it its own config option to allow easier > > customization of whether to include it. It's enabled by default in the > > same circumstances as now - when both PCI and KVM are available. > > > > Signed-off-by: David Gibson > > --- > > default-configs/pci.mak | 1 + > > hw/misc/Makefile.objs | 4 +--- > > 2 files changed, 2 insertions(+), 3 deletions(-) > > > > diff --git a/default-configs/pci.mak b/default-configs/pci.mak > > index bea6b01..58a2c0a 100644 > > --- a/default-configs/pci.mak > > +++ b/default-configs/pci.mak > > @@ -35,3 +35,4 @@ CONFIG_SDHCI=3Dy > > CONFIG_EDU=3Dy > > CONFIG_VGA=3Dy > > CONFIG_VGA_PCI=3Dy > > +CONFIG_IVSHMEM=3D$(CONFIG_KVM) >=20 > Does this create an order of definition requirement between the > configs? I guess its ok as CONFIG_KVM is defined super-early but it > seems to be avoided where one config def depends on another. Actually, I don't think it does. When "=3D" is used, rather than ":=3D" make variables are expanded when used, not when defined. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --HtRZva1Vzv8iP5ye Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJU7DznAAoJEGw4ysog2bOSRq8P/ReSXu6TtBJOVI4PrbDOV8ue AMB4BMBYsSYn76V0eGxstMx4Fadfikcelb+Zx91+pCcUpuTlTZGV3qsDO0v1ZBM0 NyVytspiqetCEAaiOnCw6Ucw2cnSBR55f04idqgkaxCPknu2U7b9gYHn+EKyfDhK z6OKSVyccbA9GsjhcB3Pu5RAeQS7NI6QILPWdJrxg/UmGf9CaFw7oyVN65yXSo1V 77TwRQ2GDY8grPk/0f0yIb24yD6owF0YEEyRVvTZvfuhHwJgrOdANSmQ7GiP/6D2 r2fsdgsazmONa9NqCu4tJ8zaKHA//y7/vBRo+tAlPgBgolWVIla080QnMEmV1p2z 4J45+uHIacPWpkrtEpPGcpqSNTEBEh6h2+eO+e98FWsjuyYs7BxCPw6JwbCQ1UZe gkPTKI7KBBoT5Zq3Gpu2hi3RIzC8afcp0vBysELNrKLqAvSwekRgJGDbJoWht5h5 BfKIC3lxTMUNDF1zUUaEPAuZgSLBbZ63SmRCjLtwx4B1StkmiQY+B9ahP4zH7yRA 8yQ8fStYdnmXQYxksY5oGsg5gvaj3EpKtXABZlzOH1soIknn/DkPolj6H+7xDhWz 9R0PXdY5DpxK4LhQQ4HVQqrVAPI6cJ9BZrooOhV1BD85zm4meMGVe3Q3vGP4Fzty DvbIa2omVxDApPPPGkXu =Rx1r -----END PGP SIGNATURE----- --HtRZva1Vzv8iP5ye--