From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45999) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQBRT-0001or-3T for qemu-devel@nongnu.org; Tue, 24 Feb 2015 04:06:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YQBRL-00068R-T9 for qemu-devel@nongnu.org; Tue, 24 Feb 2015 04:06:11 -0500 Date: Tue, 24 Feb 2015 19:57:57 +1100 From: David Gibson Message-ID: <20150224085757.GU4536@voom.redhat.com> References: <1424732702-23443-1-git-send-email-david@gibson.dropbear.id.au> <1424732702-23443-3-git-send-email-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="WcQ7DTTOeW3GIUV5" Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH 2/3] Create specific config option for "platform-bus" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite Cc: "qemu-devel@nongnu.org Developers" , Paolo Bonzini , qemu-ppc Mailing List , Alexander Graf , "Michael S. Tsirkin" --WcQ7DTTOeW3GIUV5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 23, 2015 at 10:27:20PM -0800, Peter Crosthwaite wrote: > On Mon, Feb 23, 2015 at 3:05 PM, David Gibson > wrote: > > Currently the "platform-bus" device is included for all softmmu builds. > > This bridge is intended for use on any platforms that require dynamic > > creation of sysbus devices. However, at present it is used only for the > > PPC E500 target, with plans for the ARM "virt" target in the immediate > > future. > > > > To avoid a not-very-useful entry appearing in "qemu -device ?" output on > > other targets, this patch makes a specific config option for platform-b= us > > and enables it (for now) only on ppc configurations which include E500 > > and on ARM (which always includes the "virt" target). > > > > Signed-off-by: David Gibson > > --- > > default-configs/arm-softmmu.mak | 1 + > > default-configs/ppc-softmmu.mak | 1 + > > default-configs/ppc64-softmmu.mak | 1 + > > hw/core/Makefile.objs | 2 +- > > 4 files changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/default-configs/arm-softmmu.mak b/default-configs/arm-soft= mmu.mak > > index 6ee9b43..cc2745f 100644 > > --- a/default-configs/arm-softmmu.mak > > +++ b/default-configs/arm-softmmu.mak > > @@ -79,6 +79,7 @@ CONFIG_NSERIES=3Dy > > CONFIG_REALVIEW=3Dy > > CONFIG_ZAURUS=3Dy > > CONFIG_ZYNQ=3Dy > > +CONFIG_PLATFORM_BUS=3Dy > > >=20 > This location might not fit best for this config. REALVIEW, and ZYNQ > are ARM specific boards and this logical grouping of configs seems to > be about ARM boards and their specific devs. >=20 > Should it just be in it's own category? Alternatively, the first block > of configs seems to contain all the generic stuff (like SSI, SD, > SERIAL and pci.mak) so I think it fits in that bucket most closely. I really don't know ARM well enough to have any intuition on this. I'm happy to put it wherever I'm told is best. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --WcQ7DTTOeW3GIUV5 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJU7D0VAAoJEGw4ysog2bOSwUkQAOCgojCKmEm90TV5+wotRptw 1tXGeahP/u71320J2WZfxSwTIWtb8AVeUKD1jdnEOkW+LzfKBDFTEdfNZ5HkSl3n 3MQKijvn0U09JNsQRJLbIDERBkt/v0nNbuKDZ7YapGccWHbXFkWfNP3hJivZvFHb uo5e01Tvfh4jjDo3iA6VyEZD739YucVMMsgNkFIceDmWWTss4VEggJj+qb/pRkNi M3YZ3Ye0dOkfQdVzqTmX6yJFH4zUx4/dYSpD2Pd9HLg1Sxk88jD4NmEZBnLlMx6C yopjkdCEKkxkT44B2FFyw88JVEJi1uDmZePTzPOszfd9rPtgRLpTo3Nk7Y52t0X6 bhEfWD/U3TkjQa8XkrZwAgqT4Jroe2ZBijY8+opv/L8Kd4v6Mi8Z0K4/iUPKIWT0 9CliSGlhwcrJEKUc6IxRzqs/NJDYCCgtmSlE1a5wVYs0C+E/cECd9RTcGHwizNDx 2j+f8xdUQmOG8ITfCg6xZFdYPaVgW98FKDPwNOEehMjs+RxhrVawXF6ka5mblzps wJkNQLPFjmsLQV2bX6rRgLJOBukVNww9DwNlPl1gZX4s7J5ejKHlfCPIEQGDeLdg xxtaXsYv9k+MB1BdHEjTzL76fhZq2K9S9fZuGCvvU75THovfCcDSbDBiAP/IqCgj IEpe7MF+PMikY46csse4 =ui9d -----END PGP SIGNATURE----- --WcQ7DTTOeW3GIUV5--