Re: [Qemu-devel] [PATCH v5 09/16] spapr_events: event-scan RTAS interface

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1407 bytes --]

On Mon, Feb 16, 2015 at 08:27:45AM -0600, Michael Roth wrote:
> From: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
> 
> We don't actually rely on this interface to surface hotplug events, and
> instead rely on the similar-but-interrupt-driven check-exception RTAS
> interface used for EPOW events. However, the existence of this interface
> is needed to ensure guest kernels initialize the event-reporting
> interfaces which will in turn be used by userspace tools to handle these
> events, so we implement this interface here.
> 
> Since events surfaced by this call are mutually exclusive to those
> surfaced via check-exception, we also update the RTAS event queue code
> to accept a boolean to mark/filter for events accordingly.
> 
> Events of this sort are not currently generated by QEMU, but the interface
> has been tested by surfacing hotplug events via event-scan in place
> of check-exception.
> 
> Signed-off-by: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
> Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>

Hrm, seems a little odd to implement a queue which nothing will put
events into, but it looks correct.

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]