From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1YQBnS-0000DG-7M for mharc-qemu-trivial@gnu.org; Tue, 24 Feb 2015 04:28:54 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54420) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQBnP-00008t-8f for qemu-trivial@nongnu.org; Tue, 24 Feb 2015 04:28:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YQBnK-0007QU-0e for qemu-trivial@nongnu.org; Tue, 24 Feb 2015 04:28:51 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44876) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQBnJ-0007QI-Pq; Tue, 24 Feb 2015 04:28:45 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t1O9ShTj011213 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 24 Feb 2015 04:28:43 -0500 Received: from localhost ([10.3.113.4]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t1O9SfA1013475; Tue, 24 Feb 2015 04:28:42 -0500 Date: Tue, 24 Feb 2015 14:58:29 +0530 From: Amit Shah To: Thomas Huth Message-ID: <20150224092829.GA26558@grmbl.mre> References: <1424365943-27563-1-git-send-email-thuth@linux.vnet.ibm.com> <1424365943-27563-2-git-send-email-thuth@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1424365943-27563-2-git-send-email-thuth@linux.vnet.ibm.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, Juan Quintela Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH 1/5] migration: Remove unused functions X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Feb 2015 09:28:52 -0000 On (Thu) 19 Feb 2015 [18:12:19], Thomas Huth wrote: > dup_mig_bytes_transferred(), skipped_mig_bytes_transferred(), > migrate_rdma_pin_all(), qsb_clone() and qsb_set_length() > are completely unused and thus can be deleted. > > Signed-off-by: Thomas Huth > Cc: Juan Quintela > Cc: Amit Shah > --- > arch_init.c | 10 ------- > include/migration/migration.h | 3 -- > include/migration/qemu-file.h | 2 - > migration/migration.c | 9 ------- > migration/qemu-file-buf.c | 53 ----------------------------------------- > 5 files changed, 0 insertions(+), 77 deletions(-) > > diff --git a/arch_init.c b/arch_init.c > index 89c8fa4..ad5ce28 100644 > --- a/arch_init.c > +++ b/arch_init.c > @@ -249,21 +249,11 @@ static void acct_clear(void) > memset(&acct_info, 0, sizeof(acct_info)); > } > > -uint64_t dup_mig_bytes_transferred(void) > -{ > - return acct_info.dup_pages * TARGET_PAGE_SIZE; > -} > - > uint64_t dup_mig_pages_transferred(void) > { > return acct_info.dup_pages; > } > > -uint64_t skipped_mig_bytes_transferred(void) > -{ > - return acct_info.skipped_pages * TARGET_PAGE_SIZE; > -} These could be used for reporting; Juan, any idea why these aren't used? Rest of the patch is fine. Amit From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54435) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQBnR-0000BI-0M for qemu-devel@nongnu.org; Tue, 24 Feb 2015 04:28:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YQBnQ-0007S4-4K for qemu-devel@nongnu.org; Tue, 24 Feb 2015 04:28:52 -0500 Date: Tue, 24 Feb 2015 14:58:29 +0530 From: Amit Shah Message-ID: <20150224092829.GA26558@grmbl.mre> References: <1424365943-27563-1-git-send-email-thuth@linux.vnet.ibm.com> <1424365943-27563-2-git-send-email-thuth@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1424365943-27563-2-git-send-email-thuth@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH 1/5] migration: Remove unused functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, Juan Quintela On (Thu) 19 Feb 2015 [18:12:19], Thomas Huth wrote: > dup_mig_bytes_transferred(), skipped_mig_bytes_transferred(), > migrate_rdma_pin_all(), qsb_clone() and qsb_set_length() > are completely unused and thus can be deleted. > > Signed-off-by: Thomas Huth > Cc: Juan Quintela > Cc: Amit Shah > --- > arch_init.c | 10 ------- > include/migration/migration.h | 3 -- > include/migration/qemu-file.h | 2 - > migration/migration.c | 9 ------- > migration/qemu-file-buf.c | 53 ----------------------------------------- > 5 files changed, 0 insertions(+), 77 deletions(-) > > diff --git a/arch_init.c b/arch_init.c > index 89c8fa4..ad5ce28 100644 > --- a/arch_init.c > +++ b/arch_init.c > @@ -249,21 +249,11 @@ static void acct_clear(void) > memset(&acct_info, 0, sizeof(acct_info)); > } > > -uint64_t dup_mig_bytes_transferred(void) > -{ > - return acct_info.dup_pages * TARGET_PAGE_SIZE; > -} > - > uint64_t dup_mig_pages_transferred(void) > { > return acct_info.dup_pages; > } > > -uint64_t skipped_mig_bytes_transferred(void) > -{ > - return acct_info.skipped_pages * TARGET_PAGE_SIZE; > -} These could be used for reporting; Juan, any idea why these aren't used? Rest of the patch is fine. Amit