From: Amit Shah <amit.shah@redhat.com>
To: Juan Quintela <quintela@redhat.com>
Cc: liang.z.li@intel.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 6/6] rename save_block_hdr to save_page_header
Date: Tue, 24 Feb 2015 18:18:41 +0530 [thread overview]
Message-ID: <20150224124841.GE26558@grmbl.mre> (raw)
In-Reply-To: <1423778591-12590-7-git-send-email-quintela@redhat.com>
On (Thu) 12 Feb 2015 [23:03:11], Juan Quintela wrote:
> It has always been a page header, not a block header. Once there, the
> flag argument was only passed to make a bit or with it, just do the or
> on the caller.
I prefer not to do that -- if one looks at the function signature,
he'll only notice 'offset' there and not 'offset|flag', so it's
confusing to callers of function why the | is being done for an offset
field.
Let's keep that bit as-is?
Amit
next prev parent reply other threads:[~2015-02-24 12:49 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-12 22:03 [Qemu-devel] [PATCH 0/6] migration: differentiate between pages and bytes Juan Quintela
2015-02-12 22:03 ` [Qemu-devel] [PATCH 1/6] ram: make all save_page functions take a uint64_t parameter Juan Quintela
2015-02-24 9:53 ` Amit Shah
2015-02-12 22:03 ` [Qemu-devel] [PATCH 2/6] ram_find_and_save_block: change calling convention Juan Quintela
2015-02-24 10:05 ` Amit Shah
2015-02-12 22:03 ` [Qemu-devel] [PATCH 3/6] ram_save_page: change calling covention Juan Quintela
2015-02-12 22:03 ` [Qemu-devel] [PATCH 4/6] save_xbzrle_page: change calling convention Juan Quintela
2015-02-24 10:37 ` Amit Shah
2015-03-12 15:48 ` Juan Quintela
2015-02-12 22:03 ` [Qemu-devel] [PATCH 5/6] save_block_hdr: we can recalculate the cont parameter here Juan Quintela
2015-02-26 4:49 ` Li, Liang Z
2015-03-12 15:36 ` Juan Quintela
2015-02-12 22:03 ` [Qemu-devel] [PATCH 6/6] rename save_block_hdr to save_page_header Juan Quintela
2015-02-24 12:48 ` Amit Shah [this message]
2015-02-26 4:53 ` Li, Liang Z
2015-03-12 15:44 ` Juan Quintela
2015-02-13 2:28 ` [Qemu-devel] [PATCH 0/6] migration: differentiate between pages and bytes Li, Liang Z
2015-02-17 14:23 ` Dr. David Alan Gilbert
2015-02-26 5:15 ` Li, Liang Z
2015-02-26 9:59 ` Dr. David Alan Gilbert
2015-02-26 7:05 ` Alex Bennée
2015-03-12 15:33 ` Juan Quintela
2015-03-09 2:02 ` Li, Liang Z
2015-03-12 15:33 ` Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150224124841.GE26558@grmbl.mre \
--to=amit.shah@redhat.com \
--cc=liang.z.li@intel.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.