From: Wolfram Sang <wsa@the-dreams.de>
To: Matthias Brugger <matthias.bgg@gmail.com>
Cc: linux-i2c@vger.kernel.org, linux-mips@linux-mips.org,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Ludovic Desroches <ludovic.desroches@atmel.com>,
Yingjoe Chen <yingjoe.chen@mediatek.com>,
linuxppc-dev@lists.ozlabs.org,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [RFC 02/11] i2c: add quirk checks to core
Date: Tue, 24 Feb 2015 15:16:44 +0100 [thread overview]
Message-ID: <20150224141644.GA18301@katana> (raw)
In-Reply-To: <CABuKBe++yut6ZfhPrsWXGA4fZRvum6WOuRxHucM0gBJCGuou5A@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 581 bytes --]
> > + if (msgs[i].flags & I2C_M_RD) {
> > + if (i2c_quirk_exceeded(len, max_read))
> > + return i2c_quirk_error(adap, &msgs[i], "msg too long");
> > + } else {
> > + if (i2c_quirk_exceeded(len, max_write))
> > + return i2c_quirk_error(adap, &msgs[i], "msg too long");
> > + }
>
> What about being more verbose in the error message, specifying if it
> was a read or a write message that failed?
Yes, done now. Thanks!
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: Matthias Brugger <matthias.bgg@gmail.com>
Cc: linux-mips@linux-mips.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Ludovic Desroches <ludovic.desroches@atmel.com>,
linux-i2c@vger.kernel.org,
Yingjoe Chen <yingjoe.chen@mediatek.com>,
linuxppc-dev@lists.ozlabs.org,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [RFC 02/11] i2c: add quirk checks to core
Date: Tue, 24 Feb 2015 15:16:44 +0100 [thread overview]
Message-ID: <20150224141644.GA18301@katana> (raw)
In-Reply-To: <CABuKBe++yut6ZfhPrsWXGA4fZRvum6WOuRxHucM0gBJCGuou5A@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 581 bytes --]
> > + if (msgs[i].flags & I2C_M_RD) {
> > + if (i2c_quirk_exceeded(len, max_read))
> > + return i2c_quirk_error(adap, &msgs[i], "msg too long");
> > + } else {
> > + if (i2c_quirk_exceeded(len, max_write))
> > + return i2c_quirk_error(adap, &msgs[i], "msg too long");
> > + }
>
> What about being more verbose in the error message, specifying if it
> was a read or a write message that failed?
Yes, done now. Thanks!
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: wsa@the-dreams.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC 02/11] i2c: add quirk checks to core
Date: Tue, 24 Feb 2015 15:16:44 +0100 [thread overview]
Message-ID: <20150224141644.GA18301@katana> (raw)
In-Reply-To: <CABuKBe++yut6ZfhPrsWXGA4fZRvum6WOuRxHucM0gBJCGuou5A@mail.gmail.com>
> > + if (msgs[i].flags & I2C_M_RD) {
> > + if (i2c_quirk_exceeded(len, max_read))
> > + return i2c_quirk_error(adap, &msgs[i], "msg too long");
> > + } else {
> > + if (i2c_quirk_exceeded(len, max_write))
> > + return i2c_quirk_error(adap, &msgs[i], "msg too long");
> > + }
>
> What about being more verbose in the error message, specifying if it
> was a read or a write message that failed?
Yes, done now. Thanks!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150224/e879f4a9/attachment.sig>
next prev parent reply other threads:[~2015-02-24 14:16 UTC|newest]
Thread overview: 95+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-09 17:21 [RFC 00/11] i2c: add generic quirk infrastructure Wolfram Sang
2015-01-09 17:21 ` Wolfram Sang
2015-01-09 17:21 ` Wolfram Sang
2015-01-09 17:21 ` Wolfram Sang
[not found] ` <1420824103-24169-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2015-01-09 17:21 ` [RFC 01/11] i2c: add quirk structure to describe adapter flaws Wolfram Sang
2015-01-09 17:21 ` Wolfram Sang
2015-01-09 17:21 ` Wolfram Sang
2015-01-09 17:21 ` Wolfram Sang
2015-01-16 5:50 ` Eddie Huang
2015-01-16 5:50 ` Eddie Huang
2015-01-16 5:50 ` Eddie Huang
2015-01-16 5:50 ` Eddie Huang
2015-01-19 15:05 ` Wolfram Sang
2015-01-19 15:05 ` Wolfram Sang
2015-01-19 15:05 ` Wolfram Sang
2015-01-19 15:05 ` Wolfram Sang
2015-02-24 16:04 ` Wolfram Sang
2015-02-24 16:04 ` Wolfram Sang
2015-02-24 16:04 ` Wolfram Sang
2015-02-24 16:04 ` Wolfram Sang
2015-01-16 8:18 ` Yingjoe Chen
2015-01-16 8:18 ` Yingjoe Chen
2015-01-16 8:18 ` Yingjoe Chen
2015-01-16 8:18 ` Yingjoe Chen
2015-01-19 15:00 ` Wolfram Sang
2015-01-19 15:00 ` Wolfram Sang
2015-01-19 15:00 ` Wolfram Sang
2015-01-09 17:21 ` [RFC 02/11] i2c: add quirk checks to core Wolfram Sang
2015-01-09 17:21 ` Wolfram Sang
2015-01-09 17:21 ` Wolfram Sang
2015-01-09 17:21 ` Wolfram Sang
[not found] ` <1420824103-24169-3-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2015-01-09 19:35 ` Sergei Shtylyov
2015-01-09 19:35 ` Sergei Shtylyov
2015-01-09 19:35 ` Sergei Shtylyov
2015-01-09 19:35 ` Sergei Shtylyov
[not found] ` <54B02D7F.7040501-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2015-01-09 20:45 ` Wolfram Sang
2015-01-09 20:45 ` Wolfram Sang
2015-01-09 20:45 ` Wolfram Sang
2015-01-09 20:45 ` Wolfram Sang
2015-01-09 21:05 ` Sergei Shtylyov
2015-01-09 21:05 ` Sergei Shtylyov
2015-01-09 21:05 ` Sergei Shtylyov
2015-01-09 21:05 ` Sergei Shtylyov
2015-01-12 9:58 ` Ludovic Desroches
2015-01-12 9:58 ` Ludovic Desroches
2015-01-12 9:58 ` Ludovic Desroches
2015-01-12 9:58 ` Ludovic Desroches
2015-01-12 9:58 ` Ludovic Desroches
2015-01-12 10:13 ` Wolfram Sang
2015-01-12 10:13 ` Wolfram Sang
2015-01-12 10:13 ` Wolfram Sang
2015-01-12 12:08 ` Russell King - ARM Linux
2015-01-12 12:08 ` Russell King - ARM Linux
2015-01-12 12:08 ` Russell King - ARM Linux
2015-01-12 12:08 ` Russell King - ARM Linux
[not found] ` <20150112120814.GE12302-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2015-02-24 14:25 ` Wolfram Sang
2015-02-24 14:25 ` Wolfram Sang
2015-02-24 14:25 ` Wolfram Sang
2015-02-24 14:25 ` Wolfram Sang
2015-01-12 13:15 ` Matthias Brugger
2015-01-12 13:15 ` Matthias Brugger
2015-01-12 13:15 ` Matthias Brugger
2015-01-12 13:15 ` Matthias Brugger
2015-02-24 14:16 ` Wolfram Sang [this message]
2015-02-24 14:16 ` Wolfram Sang
2015-02-24 14:16 ` Wolfram Sang
2015-01-09 17:21 ` [RFC 03/11] i2c: at91: make use of the new infrastructure for quirks Wolfram Sang
2015-01-09 17:21 ` Wolfram Sang
2015-01-09 17:21 ` Wolfram Sang
2015-01-09 17:21 ` Wolfram Sang
2015-01-09 17:21 ` [RFC 04/11] i2c: opal: " Wolfram Sang
2015-01-09 17:21 ` Wolfram Sang
2015-01-09 17:21 ` Wolfram Sang
2015-01-09 17:21 ` [RFC 05/11] i2c: qup: " Wolfram Sang
2015-01-09 17:21 ` Wolfram Sang
2015-01-09 17:21 ` Wolfram Sang
2015-01-09 17:21 ` Wolfram Sang
2015-01-09 17:21 ` [RFC 06/11] i2c: cpm: " Wolfram Sang
2015-01-09 17:21 ` Wolfram Sang
2015-01-09 17:21 ` Wolfram Sang
2015-01-09 17:21 ` [RFC 07/11] i2c: axxia: " Wolfram Sang
2015-01-09 17:21 ` Wolfram Sang
2015-01-09 17:21 ` Wolfram Sang
2015-01-09 17:21 ` [RFC 08/11] i2c: dln2: " Wolfram Sang
2015-01-09 17:21 ` Wolfram Sang
2015-01-09 17:21 ` Wolfram Sang
2015-01-09 17:21 ` [RFC 09/11] i2c: powermac: " Wolfram Sang
2015-01-09 17:21 ` Wolfram Sang
2015-01-09 17:21 ` Wolfram Sang
2015-01-09 17:21 ` [RFC 10/11] i2c: viperboard: " Wolfram Sang
2015-01-09 17:21 ` Wolfram Sang
2015-01-09 17:21 ` Wolfram Sang
2015-01-09 17:21 ` [RFC 11/11] i2c: pmcmsp: " Wolfram Sang
2015-01-09 17:21 ` Wolfram Sang
2015-01-09 17:21 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150224141644.GA18301@katana \
--to=wsa@the-dreams.de \
--cc=benh@kernel.crashing.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=ludovic.desroches@atmel.com \
--cc=matthias.bgg@gmail.com \
--cc=yingjoe.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.