All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Vatika Harlalka <vatikaharlalka@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH 1/2 v2] Introduce new macro
Date: Tue, 24 Feb 2015 06:18:45 -0800	[thread overview]
Message-ID: <20150224141845.GA16196@kroah.com> (raw)
In-Reply-To: <CAHjTdYeJwoC26O-c1oWWaTtdxRfBegggu1fS0qXj+LwLoii5Wg@mail.gmail.com>

On Tue, Feb 24, 2015 at 01:27:46PM +0530, Vatika Harlalka wrote:
> Hi, thanks for your response!
> 
> I'm using this macro in� /rtl8188eu/hal/phy.c ( in patch 2/2 ).
> > u8 channel_5g[ODM_TARGET_CHNL_NUM_5G]
> However, based on your response, I will make this array static const int,
> so I won't explicitly declare the size.
> Should I resend a patch for this with just that fix?

Why 'int'?

And watch out for your email client settings, you are sending html email
which the linux-kernel mailing lists will reject.

thanks,

greg k-h


  reply	other threads:[~2015-02-24 14:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-24  7:24 [PATCH 0/2 v2] Refactor code to increase readability Vatika Harlalka
2015-02-24  7:25 ` [PATCH 1/2 v2] Introduce new macro Vatika Harlalka
2015-02-24  7:40   ` [Outreachy kernel] " Greg KH
2015-02-24  7:57     ` Vatika Harlalka
2015-02-24 14:18       ` Greg KH [this message]
2015-02-26 12:26         ` Vatika Harlalka
2015-02-24  7:26 ` [PATCH 2/2 v2] Staging: rtl8188eu: Refactor code to increase readability Vatika Harlalka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150224141845.GA16196@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=outreachy-kernel@googlegroups.com \
    --cc=vatikaharlalka@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.