From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: Nokia N900: omap aes is broken Date: Tue, 24 Feb 2015 09:37:34 -0800 Message-ID: <20150224173734.GD28244@atomide.com> References: <201502181321.03774@pali> <201502182227.55488@pali> <20150224172512.GC28244@atomide.com> <201502241838.44317@pali> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Nishanth Menon , Felipe Balbi , Ivaylo Dimitrov , Aaro Koskinen , Sebastian Reichel , Pavel Machek , linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-crypto@vger.kernel.org To: Pali =?utf-8?B?Um9ow6Fy?= Return-path: Content-Disposition: inline In-Reply-To: <201502241838.44317@pali> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-crypto.vger.kernel.org * Pali Roh=C3=A1r [150224 09:42]: > On Tuesday 24 February 2015 18:25:12 Tony Lindgren wrote: > > * Pali Roh=C3=A1r [150218 16:03]: > > > --- a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c > > > +++ b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c > > > @@ -3938,8 +3938,9 @@ int __init omap3xxx_hwmod_init(void) > > >=20 > > > if (r < 0) > > > =09 > > > return r; > > >=20 > > > - /* Register GP-only hwmod links. */ > > > - if (h_gp && omap_type() =3D=3D OMAP2_DEVICE_TYPE_GP) { > > > +// /* Register GP-only hwmod links. */ > > > +// if (h_gp && omap_type() =3D=3D OMAP2_DEVICE_TYPE_GP) { > > > + if (h_gp) { > > >=20 > > > r =3D omap_hwmod_register_links(h_gp); > > > if (r < 0) > > > =09 > > > return r; > > >=20 > > > aes hwmod is defined in GP-only hwmod... > >=20 > > Doesn't this depend on the bootloader version of n900 to work? > >=20 > > Regards, > >=20 > > Tony >=20 > Ok, it looks like second patch (omap_hwmod_3xxx_data.c) needs=20 > that aes-enabled bootloader. OK we need some runtime detection somehow for what's enabled.. =20 > But first patch (omap3.dtsi) is needed for proper definitions.=20 > Otherwise omap-aes driver will never work on DT systems. Yeah that one makes sense to me, I guess you'll do a proper fix for that one. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753458AbbBXRvz (ORCPT ); Tue, 24 Feb 2015 12:51:55 -0500 Received: from pmta2.delivery2.ore.mailhop.org ([54.69.130.42]:43008 "EHLO pmta2.delivery2.ore.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752769AbbBXRvy (ORCPT ); Tue, 24 Feb 2015 12:51:54 -0500 X-Mail-Handler: DuoCircle Outbound SMTP X-Originating-IP: 104.193.169.186 X-Report-Abuse-To: abuse@duocircle.com (see https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information for abuse reporting information) X-MHO-User: U2FsdGVkX1+PN7kXFkQzn0x4IY3ZeMXV Date: Tue, 24 Feb 2015 09:37:34 -0800 From: Tony Lindgren To: Pali =?utf-8?B?Um9ow6Fy?= Cc: Nishanth Menon , Felipe Balbi , Ivaylo Dimitrov , Aaro Koskinen , Sebastian Reichel , Pavel Machek , linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-crypto@vger.kernel.org Subject: Re: Nokia N900: omap aes is broken Message-ID: <20150224173734.GD28244@atomide.com> References: <201502181321.03774@pali> <201502182227.55488@pali> <20150224172512.GC28244@atomide.com> <201502241838.44317@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <201502241838.44317@pali> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Pali Rohár [150224 09:42]: > On Tuesday 24 February 2015 18:25:12 Tony Lindgren wrote: > > * Pali Rohár [150218 16:03]: > > > --- a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c > > > +++ b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c > > > @@ -3938,8 +3938,9 @@ int __init omap3xxx_hwmod_init(void) > > > > > > if (r < 0) > > > > > > return r; > > > > > > - /* Register GP-only hwmod links. */ > > > - if (h_gp && omap_type() == OMAP2_DEVICE_TYPE_GP) { > > > +// /* Register GP-only hwmod links. */ > > > +// if (h_gp && omap_type() == OMAP2_DEVICE_TYPE_GP) { > > > + if (h_gp) { > > > > > > r = omap_hwmod_register_links(h_gp); > > > if (r < 0) > > > > > > return r; > > > > > > aes hwmod is defined in GP-only hwmod... > > > > Doesn't this depend on the bootloader version of n900 to work? > > > > Regards, > > > > Tony > > Ok, it looks like second patch (omap_hwmod_3xxx_data.c) needs > that aes-enabled bootloader. OK we need some runtime detection somehow for what's enabled.. > But first patch (omap3.dtsi) is needed for proper definitions. > Otherwise omap-aes driver will never work on DT systems. Yeah that one makes sense to me, I guess you'll do a proper fix for that one. Regards, Tony