From mboxrd@z Thu Jan 1 00:00:00 1970 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH 2/2] leds/pwm: Don't disable pwm when setting brightness to 0 Date: Wed, 25 Feb 2015 09:42:54 +0100 Message-ID: <20150225084254.GI7789@pengutronix.de> References: <1423734290-19750-1-git-send-email-u.kleine-koenig@pengutronix.de> <1423734290-19750-3-git-send-email-u.kleine-koenig@pengutronix.de> <1151818200.134325.1424804213026.JavaMail.open-xchange@oxbsltgw03.schlund.de> <20150224190636.GG7789@pengutronix.de> <54ED8426.6090401@i2se.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from metis.ext.pengutronix.de ([92.198.50.35]:47497 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753393AbbBYInG (ORCPT ); Wed, 25 Feb 2015 03:43:06 -0500 Content-Disposition: inline In-Reply-To: <54ED8426.6090401@i2se.com> Sender: linux-leds-owner@vger.kernel.org List-Id: linux-leds@vger.kernel.org To: Stefan Wahren Cc: linux-pwm@vger.kernel.org, Sascha Hauer , Bryan Wu , Thierry Reding , Richard Purdie , linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de, linux-leds@vger.kernel.org Hello Stefan, On Wed, Feb 25, 2015 at 09:13:26AM +0100, Stefan Wahren wrote: > Tested-by: Stefan Wahren Thanks. > >> This is the functional part of this issue, since the warning has b= een fixed [1] > > Can I interpret this as an Tested-by: for this patch and an Ack for > > patch 1? >=20 > Sorry, but i don't think i'm the right person for acking patch 1. IMHO it doesn't matter who you are for an ack. You can consider it righ= t and tell it. How much this ack is useful to convince a maintainer to take this patch is a different story. But given that I try to fix the problem at hand for >2 years and I'm stuck because Thierry isn't convinced that it's a correct way to go forward but also doesn't come up with an alternative I'm happy about everyone who gives his/her opinion. Still more if the opinion matches mine. Thanks Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig = | Industrial Linux Solutions | http://www.pengutronix.de/= | From mboxrd@z Thu Jan 1 00:00:00 1970 From: u.kleine-koenig@pengutronix.de (Uwe =?iso-8859-1?Q?Kleine-K=F6nig?=) Date: Wed, 25 Feb 2015 09:42:54 +0100 Subject: [PATCH 2/2] leds/pwm: Don't disable pwm when setting brightness to 0 In-Reply-To: <54ED8426.6090401@i2se.com> References: <1423734290-19750-1-git-send-email-u.kleine-koenig@pengutronix.de> <1423734290-19750-3-git-send-email-u.kleine-koenig@pengutronix.de> <1151818200.134325.1424804213026.JavaMail.open-xchange@oxbsltgw03.schlund.de> <20150224190636.GG7789@pengutronix.de> <54ED8426.6090401@i2se.com> Message-ID: <20150225084254.GI7789@pengutronix.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello Stefan, On Wed, Feb 25, 2015 at 09:13:26AM +0100, Stefan Wahren wrote: > Tested-by: Stefan Wahren Thanks. > >> This is the functional part of this issue, since the warning has been fixed [1] > > Can I interpret this as an Tested-by: for this patch and an Ack for > > patch 1? > > Sorry, but i don't think i'm the right person for acking patch 1. IMHO it doesn't matter who you are for an ack. You can consider it right and tell it. How much this ack is useful to convince a maintainer to take this patch is a different story. But given that I try to fix the problem at hand for >2 years and I'm stuck because Thierry isn't convinced that it's a correct way to go forward but also doesn't come up with an alternative I'm happy about everyone who gives his/her opinion. Still more if the opinion matches mine. Thanks Uwe -- Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ |