From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37743) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQZeZ-0002gP-Vq for qemu-devel@nongnu.org; Wed, 25 Feb 2015 05:57:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YQZeU-0001lR-WE for qemu-devel@nongnu.org; Wed, 25 Feb 2015 05:57:19 -0500 Received: from smtp3.mundo-r.com ([212.51.32.191]:57956 helo=smtp4.mundo-r.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQZeU-0001g4-PJ for qemu-devel@nongnu.org; Wed, 25 Feb 2015 05:57:14 -0500 Date: Wed, 25 Feb 2015 11:56:35 +0100 From: Alberto Garcia Message-ID: <20150225105635.GA14590@igalia.com> References: <14cbc4c207ba6451894101aae39d146144a3c6dc.1423842044.git.berto@igalia.com> <54ECACB5.9030406@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54ECACB5.9030406@redhat.com> Subject: Re: [Qemu-devel] [PATCH 9/9] throttle: add name of ThrottleGroup to BlockDeviceInfo List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Kevin Wolf , qemu-devel@nongnu.org, Stefan Hajnoczi On Tue, Feb 24, 2015 at 09:54:13AM -0700, Eric Blake wrote: > Questions - with this series in place, is it ever possible to have > throttling parameters without a throttle group name? Yes, and it will work the same as before. If the throttling parameters are set but no group name is specified then we auto-generate one. > When using block_set_io_throttle, is it legal to pass parameters > (like bps_max) and a group name at the same time Yes, you're actually supposed to do it like that. If the group does not exist yet, it's created on the fly. If the group name is not set, then we auto-generate one. > and if so, what happens if there is already a throttle group by that > name? All members of the same group share the same ThrottleState configuration (it's stored in the group), so when you set the throttling parameters you set them for the whole group. For the same reason, removing a member from the group doesn't change the throttling parameters. But once the group is empty, it is destroyed. > Is there a command that can return the list of all throttle group > names? Not currently, but I think I can add one easily. Any suggestion for the name of the command, and for the data that you would like it to return? Berto