From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] drivers: cpuidle: Explictly include proc-fns.h for cpuidle-arm64
Date: Wed, 25 Feb 2015 11:18:29 +0000 [thread overview]
Message-ID: <20150225111828.GA9714@leverpostej> (raw)
In-Reply-To: <1424827506-12245-1-git-send-email-lauraa@codeaurora.org>
Hi Laura,
On Wed, Feb 25, 2015 at 01:25:06AM +0000, Laura Abbott wrote:
> cpuidle-arm64.c fails to compile with CONFIG_ARM64_64K_PAGES=y
>
> /kernel/drivers/cpuidle/cpuidle-arm64.c: In function "arm64_enter_idle_state"
> /kernel/drivers/cpuidle/cpuidle-arm64.c:42:3: error: implicit declaration of function "cpu_do_idle" [-Werror=implicit-function-declaration]
> cpu_do_idle();
> ^
>
> Explicitly add the header file with the declaration of cpu_do_idle.
>
> Signed-off-by: Laura Abbott <lauraa@codeaurora.org>
I just hit the same problem. The fix looks sane, and it would be nice to
have it queued ASAP.
> ---
> Not sure how long this has been broken, bisect between v3.19 and master showed
> 6b00f7efb5303418c231994c91fb8239f5ada260 as the first bad commit which
> isn't particularly helpful. Probably some header shuffling.
> ---
> drivers/cpuidle/cpuidle-arm64.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/cpuidle/cpuidle-arm64.c b/drivers/cpuidle/cpuidle-arm64.c
> index 80704b9..f1d5422 100644
> --- a/drivers/cpuidle/cpuidle-arm64.c
> +++ b/drivers/cpuidle/cpuidle-arm64.c
> @@ -19,6 +19,7 @@
> #include <linux/of.h>
>
> #include <asm/cpuidle.h>
> +#include <asm/proc-fns.h>
> #include <asm/suspend.h>
I wasn't able to apply this patch atop of v4.0-rc1 or current mainline;
there's no asm/suspend.h include in either of those. Which tree is this
based on?
Mark.
next prev parent reply other threads:[~2015-02-25 11:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-25 1:25 [PATCH] drivers: cpuidle: Explictly include proc-fns.h for cpuidle-arm64 Laura Abbott
2015-02-25 8:31 ` Lorenzo Pieralisi
2015-02-25 11:18 ` Mark Rutland [this message]
2015-02-25 11:27 ` Lorenzo Pieralisi
2015-02-25 11:39 ` Mark Rutland
2015-02-25 18:04 ` Laura Abbott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150225111828.GA9714@leverpostej \
--to=mark.rutland@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.