From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42668)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berto@igalia.com>) id 1YQe1W-0007rY-29
	for qemu-devel@nongnu.org; Wed, 25 Feb 2015 10:37:18 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <berto@igalia.com>) id 1YQe1T-0005DE-BM
	for qemu-devel@nongnu.org; Wed, 25 Feb 2015 10:37:18 -0500
Received: from smtp3.mundo-r.com ([212.51.32.191]:64368 helo=smtp4.mundo-r.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berto@igalia.com>) id 1YQe1T-0005Ai-2L
	for qemu-devel@nongnu.org; Wed, 25 Feb 2015 10:37:15 -0500
Date: Wed, 25 Feb 2015 16:37:12 +0100
From: Alberto Garcia <berto@igalia.com>
Message-ID: <20150225153712.GA11717@igalia.com>
References: <cover.1423842044.git.berto@igalia.com>
	<14cbc4c207ba6451894101aae39d146144a3c6dc.1423842044.git.berto@igalia.com>
	<54ECACB5.9030406@redhat.com> <20150225105635.GA14590@igalia.com>
	<54EDE8DE.1000701@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <54EDE8DE.1000701@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 9/9] throttle: add name of ThrottleGroup to
 BlockDeviceInfo
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

On Wed, Feb 25, 2015 at 08:23:10AM -0700, Eric Blake wrote:

> >> Is there a command that can return the list of all throttle group
> >> names?
> > 
> > Not currently, but I think I can add one easily. Any suggestion
> > for the name of the command, and for the data that you would like
> > it to return?
> 
> How about query-block-throttle, returning an array of dicts.  Ideas
> for what it could contain would be the name of the block group, its
> current settings, and the node names associated with the group.
> Maybe something like:
> 
> => { "execute":"query-block-throttle" }
> <= { "return": [
>      { "name": "throttle1", "bps_max": 100000,
>        "nodes": [ "block0", "block1" ] },
>      { "name": "throttle2", "iops_max": 10000,
>        "nodes": [ "block2" ] }
>    ] }

Sounds reasonable, I think it should be easily doable, I can give it a
try.

One thing to note, not that it's directly related to group throttling,
but as far as I'm aware the current throttling code cannot be used in
arbitrary nodes, only in the root (block_set_io_throttle receives a
device name).

Berto