Re: [Outreachy kernel] [PATCH 2/2] Staging: emxx_udc: Replace printk with pr_err

[Greg KH <gregkh@linuxfoundation.org>]

On Wed, Feb 25, 2015 at 07:20:28PM +0300, Haneen Mohammed wrote:
> On Tue, Feb 24, 2015 at 03:25:29PM -0800, Greg KH wrote:
> > On Sat, Feb 21, 2015 at 09:59:55PM +0100, Julia Lawall wrote:
> > > On Sat, 21 Feb 2015, Haneen Mohammed wrote:
> > > 
> > > > This patch replaces printk(KERN_ERR .. with pr_err, to fix the following
> > > > checkpatch.pl warning:
> > > > WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev,  ... then
> > > > dev_err(dev,  ... then pr_err(...  to printk(KERN_ERR ...
> > > > 
> > > > Signed-off-by: Haneen Mohammed <hamohammed.sa@gmail.com>
> > > > ---
> > > >  drivers/staging/emxx_udc/emxx_udc.h | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > 
> > > > diff --git a/drivers/staging/emxx_udc/emxx_udc.h b/drivers/staging/emxx_udc/emxx_udc.h
> > > > index c1f98b3..c3fd7f6 100644
> > > > --- a/drivers/staging/emxx_udc/emxx_udc.h
> > > > +++ b/drivers/staging/emxx_udc/emxx_udc.h
> > > > @@ -644,6 +644,6 @@ volatile union usb_reg_access {
> > > >  };
> > > >  
> > > >  /*-------------------------------------------------------------------------*/
> > > > -#define ERR(stuff...)		printk(KERN_ERR "udc: " stuff)
> > > > +#define ERR(stuff...)		pr_err("udc: " stuff)
> > > 
> > > A better approach would be to remove ERR completely, and see which 
> > > standard kernel debugging function (pr_err?, dev_err?) could be used at 
> > > each point.
> > 
> > Ideally dev_err() should be used, just drop ERR() entirely please.
> > 
> > thanks,
> > 
> > greg k-h
> 
> I did drop ERR() macro and sent it as new patchset. the last revision
> was "[PATCH v5 0/6] Staging: emxx_udc: Fix checkpatch.pl warnings"

Great, thanks for this, still sifting through the submissions, in order,
so I hadn't gotten to these yet.

greg k-h