From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Wed, 25 Feb 2015 18:30:41 +0000 Subject: Re: [patch] hfsplus: add missing curly braces in hfsplus_delete_cat() Message-Id: <20150225183041.GG5116@mwanda> List-Id: References: <20150225133644.GW19745@mwanda> <20150225171303.GF5116@mwanda> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Sergei Antonov Cc: Andrew Morton , Vyacheslav Dubeyko , Sougata Santra , Christoph Hellwig , "linux-fsdevel@vger.kernel.org" , kernel-janitors@vger.kernel.org Gar. No, I don't care about "if (unlikely(err < 0)" or "if (unlikely(err)) ". Those seem like petty things to me so I'm not getting involved with the argument between the two of you. (My secret real opinion, is that I doubt anyone benchmarked it so probably the unlikely() annotations hurt readability for no good reason. In other words, "if (err)" is correct.) regards, dan carpenter From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: Re: [patch] hfsplus: add missing curly braces in hfsplus_delete_cat() Date: Wed, 25 Feb 2015 21:30:41 +0300 Message-ID: <20150225183041.GG5116@mwanda> References: <20150225133644.GW19745@mwanda> <20150225171303.GF5116@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Andrew Morton , Vyacheslav Dubeyko , Sougata Santra , Christoph Hellwig , "linux-fsdevel@vger.kernel.org" , kernel-janitors@vger.kernel.org To: Sergei Antonov Return-path: Content-Disposition: inline In-Reply-To: Sender: kernel-janitors-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Gar. No, I don't care about "if (unlikely(err < 0)" or "if (unlikely(err)) ". Those seem like petty things to me so I'm not getting involved with the argument between the two of you. (My secret real opinion, is that I doubt anyone benchmarked it so probably the unlikely() annotations hurt readability for no good reason. In other words, "if (err)" is correct.) regards, dan carpenter