From: Sebastian Reichel <sre@kernel.org>
To: NeilBrown <neilb@suse.de>
Cc: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
David Woodhouse <dwmw2@infradead.org>,
Felipe Balbi <balbi@ti.com>,
GTA04 owners <gta04-owner@goldelico.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: Re: [PATCH 2/2] twl4030_charger: find associated phy by more reliable means.
Date: Wed, 25 Feb 2015 22:13:51 +0100 [thread overview]
Message-ID: <20150225211351.GH13695@earth> (raw)
In-Reply-To: <20150224040129.32252.59874.stgit@notabene.brown>
[-- Attachment #1: Type: text/plain, Size: 767 bytes --]
Hi Neil,
On Tue, Feb 24, 2015 at 03:01:29PM +1100, NeilBrown wrote:
> twl4030_charger currently finds the associated phy
> using usb_get_phy() which will return the first USB2 phy.
> If your platform has multiple such phys (as mine does),
> this is not reliable (and reliably fails on the GTA04).
>
> Change to use devm_usb_get_phy_by_node(), having found the
> node by looking for an appropriately named sibling in
> device-tree.
>
> This makes usb-charging dependent on correct device-tree
> configuration.
The patch looks ok to me, but you should update the DT documentation
in Documentation/devicetree/bindings/power/twl-charger.txt regarding
the sibling dependency.
Apart from that DT binding maintainers should be CC'd.
-- Sebastian
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-02-25 21:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-24 4:01 [PATCH 0/2] Allow twl4030_charger to find phy reliably NeilBrown
2015-02-24 4:01 ` [PATCH 1/2] usb: phy: Add interface to get phy give of device_node NeilBrown
2015-02-24 4:01 ` [PATCH 2/2] twl4030_charger: find associated phy by more reliable means NeilBrown
2015-02-25 21:13 ` Sebastian Reichel [this message]
2015-03-04 9:14 ` NeilBrown
2015-03-02 21:05 ` [PATCH 0/2] Allow twl4030_charger to find phy reliably Pavel Machek
-- strict thread matches above, loose matches on Subject: below --
2015-03-22 22:52 NeilBrown
2015-03-22 22:52 ` [PATCH 2/2] twl4030_charger: find associated phy by more reliable means NeilBrown
2015-05-08 16:12 ` Felipe Balbi
2015-05-08 16:12 ` Felipe Balbi
[not found] ` <20150508161205.GE16571-HgARHv6XitJaoMGHk7MhZQC/G2K4zDHf@public.gmane.org>
2015-05-17 9:56 ` Sebastian Reichel
2015-05-17 9:56 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150225211351.GH13695@earth \
--to=sre@kernel.org \
--cc=balbi@ti.com \
--cc=dbaryshkov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=gta04-owner@goldelico.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.