From: Bastian Bittorf <bittorf@bluebottle.com>
To: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2 0/10] Improve Minstrels & Minstrel-HTs common code base & statistics
Date: Wed, 25 Feb 2015 22:18:17 +0100 [thread overview]
Message-ID: <20150225211817.GC8189@medion.lan> (raw)
In-Reply-To: <1423839472-15625-1-git-send-email-thomas@net.t-labs.tu-berlin.de>
* Job <thomas@net.t-labs.tu-berlin.de> [13.02.2015 16:32]:
> This patch series adds several improvements to the readability, the
> output format of rc_stats and the calculated statistics of Minstrel
> and Minstrel-HT. Variable names got more consistent and functions
> got unified between both rate control algorithms.
i did intensive testing in our small testnet (~50 routers) with all
kinds of platforms (ar71xx, x86, mpc85xx/ppc) and have no objections
for this patch-series but a big "thumbs up" for very nice, readable
and machine-parseable minstrel/rate-selector-output:
root@KuechenJukebox:~ cat /sys/kernel/debug/ieee80211/phy0/netdev:wlan0/stations/f4:ec:38:9d:81:f0/rc_stats
best ____________rate__________ ___________statistics__________ ________last_______ ______sum-of________
mode guard # rate [name idx airtime max_tp] [ ø(tp) ø-2σ(tp) ø(prob) σ(prob)] [prob.|retry|suc|att] [#success | #attempts]
CCK LP 1 1.0M 120 10548 0.9 0.0 0.0 6.4 1.6 5.2 2 0 0 74 585
CCK LP 1 2.0M 121 5476 1.8 0.0 0.0 0.0 0.0 0.0 0 0 0 0 2
CCK LP 1 5.5M 122 2411 4.1 0.0 0.0 0.0 0.0 0.0 0 0 0 0 2
CCK LP 1 11.0M 123 1535 6.5 1.2 1.1 18.7 0.7 0.0 0 0 0 1 3
HT20 LGI 1 CD MCS0 0 1480 6.5 3.3 3.2 52.7 1.2 33.3 2 0 0 320 657
HT20 LGI 1 A P MCS1 1 740 12.5 9.9 9.7 79.8 0.9 100.0 3 2 2 645 1234
HT20 LGI 1 MCS2 2 496 18.1 0.0 0.0 0.0 0.0 0.0 0 0 0 0 3
HT20 LGI 1 MCS3 3 372 23.4 1.9 1.3 8.8 1.5 0.0 5 0 0 69 281
HT20 LGI 1 MCS4 4 248 33.1 0.0 0.0 0.0 0.0 0.0 0 0 0 0 2
HT20 LGI 1 MCS5 5 188 41.3 0.0 0.0 0.0 0.0 0.0 0 0 0 0 3
HT20 LGI 1 MCS6 6 168 45.0 0.0 0.0 0.0 0.0 0.0 0 0 0 0 3
HT20 LGI 1 MCS7 7 148 49.5 0.0 0.0 0.0 0.0 0.0 0 0 0 0 3
HT20 LGI 2 MCS8 10 740 12.5 0.0 0.0 0.0 0.0 0.0 0 0 0 0 2
HT20 LGI 2 B MCS9 11 372 23.4 7.4 6.8 32.4 1.6 0.0 4 0 8 10 27
HT20 LGI 2 MCS10 12 248 33.1 0.0 0.0 0.0 0.0 0.0 0 0 0 0 2
HT20 LGI 2 MCS11 13 188 41.3 0.0 0.0 0.0 0.0 0.0 0 0 0 0 3
HT20 LGI 2 MCS12 14 124 56.1 0.0 0.0 0.0 0.0 0.0 0 0 0 0 3
HT20 LGI 2 MCS13 15 96 66.6 0.0 0.0 0.0 0.0 0.0 0 0 0 0 3
HT20 LGI 2 MCS14 16 84 72.4 0.0 0.0 0.0 0.0 0.0 0 0 0 0 3
HT20 LGI 2 MCS15 17 76 76.9 0.0 0.0 0.0 0.0 0.0 0 0 0 0 3
Total packet count:: ideal 1023 lookaround 48
Average # of aggregated frames per A-MPDU: 2.7
root@KuechenJukebox:~ cat /sys/kernel/debug/ieee80211/phy0/netdev:wlan0/stations/f4:ec:38:9d:81:f0/rc_stats_csv
1424897596.239275,CCK,LP,1,,,,,, 1.0M,120,10548,0.9,0.0,0.0,0.0,0.0,0.0,0,0,0,0,0,0,0,1.0
1424897596.239275,CCK,LP,1,,,,,, 2.0M,121,5476,1.8,0.0,0.0,0.0,0.0,0.0,0,0,0,0,0,0,0,1.0
1424897596.239275,CCK,LP,1,,,,,, 5.5M,122,2411,4.1,0.0,0.0,0.0,0.0,0.0,0,0,0,0,0,0,0,1.0
1424897596.239275,CCK,LP,1,,,,,,11.0M,123,1535,6.5,0.0,0.0,0.0,0.0,0.0,0,0,0,0,0,0,0,1.0
1424897596.239275,HT20,LGI,1,A,B,C,D,P,MCS0 ,0,1480,6.2,0.0,0.0,0.0,0.0,0.0,1,0,0,0,0,0,0,1.0
1424897596.239275,HT20,LGI,1,,,,,,MCS1 ,1,740,11.7,0.0,0.0,0.0,0.0,0.0,0,0,0,0,0,0,0,1.0
1424897596.239275,HT20,LGI,1,,,,,,MCS2 ,2,496,16.5,0.0,0.0,0.0,0.0,0.0,0,0,0,0,0,0,0,1.0
1424897596.239275,HT20,LGI,1,,,,,,MCS3 ,3,372,20.8,0.0,0.0,0.0,0.0,0.0,0,0,0,0,0,0,0,1.0
1424897596.239275,HT20,LGI,1,,,,,,MCS4 ,4,248,28.0,0.0,0.0,0.0,0.0,0.0,0,0,0,0,0,0,0,1.0
1424897596.239275,HT20,LGI,1,,,,,,MCS5 ,5,188,33.7,0.0,0.0,0.0,0.0,0.0,0,0,0,0,0,0,0,1.0
1424897596.239275,HT20,LGI,1,,,,,,MCS6 ,6,168,36.2,0.0,0.0,0.0,0.0,0.0,0,0,0,0,0,0,0,1.0
1424897596.239275,HT20,LGI,1,,,,,,MCS7 ,7,148,39.0,0.0,0.0,0.0,0.0,0.0,0,0,0,0,0,0,0,1.0
1424897596.239275,HT20,LGI,2,,,,,,MCS8 ,10,740,11.7,0.0,0.0,0.0,0.0,0.0,0,0,0,0,0,0,0,1.0
1424897596.239275,HT20,LGI,2,,,,,,MCS9 ,11,372,20.8,0.0,0.0,0.0,0.0,0.0,0,0,0,0,0,0,0,1.0
1424897596.239275,HT20,LGI,2,,,,,,MCS10,12,248,28.0,0.0,0.0,0.0,0.0,0.0,0,0,0,0,0,0,0,1.0
1424897596.239275,HT20,LGI,2,,,,,,MCS11,13,188,33.7,0.0,0.0,0.0,0.0,0.0,0,0,0,0,0,0,0,1.0
1424897596.239275,HT20,LGI,2,,,,,,MCS12,14,124,43.1,0.0,0.0,0.0,0.0,0.0,0,0,0,0,0,0,0,1.0
1424897596.239275,HT20,LGI,2,,,,,,MCS13,15,96,49.0,0.0,0.0,0.0,0.0,0.0,0,0,0,0,0,0,0,1.0
1424897596.239275,HT20,LGI,2,,,,,,MCS14,16,84,52.0,0.0,0.0,0.0,0.0,0.0,0,0,0,0,0,0,0,1.0
1424897596.239275,HT20,LGI,2,,,,,,MCS15,17,76,54.3,0.0,0.0,0.0,0.0,0.0,0,0,0,0,0,0,0,1.0
so a just want to say:
Tested-by: Bastian Bittorf
prev parent reply other threads:[~2015-02-25 21:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-13 14:57 [PATCH v2 0/10] Improve Minstrels & Minstrel-HTs common code base & statistics Thomas Huehn
2015-02-13 14:57 ` [PATCH v2 01/10] mac80211: enhance readability of Minstrels rc_stats output Thomas Huehn
2015-02-13 14:57 ` [PATCH v2 02/10] mac80211: enhance readability of Minstrel-HTs " Thomas Huehn
2015-02-13 14:57 ` [PATCH v2 03/10] mac80211: add new Minstrel statistic output via csv Thomas Huehn
2015-03-17 8:16 ` Felix Fietkau
2015-02-13 14:57 ` [PATCH v2 04/10] mac80211: add new Minstrel-HT " Thomas Huehn
2015-03-17 8:18 ` Felix Fietkau
2015-02-13 14:57 ` [PATCH v2 05/10] mac80211: unify Minstrel & Minstrel-HTs calculation of rate statistics Thomas Huehn
2015-02-13 14:57 ` [PATCH v2 06/10] mac80211: improve Minstrel variable & function naming Thomas Huehn
2015-02-13 14:57 ` [PATCH v2 07/10] mac80211: restructure per-rate throughput calculation into function Thomas Huehn
2015-03-17 8:24 ` Felix Fietkau
2015-02-13 14:57 ` [PATCH v2 08/10] mac80211: add max. lossless throughput per rate to rc_stats Thomas Huehn
2015-03-17 8:32 ` Felix Fietkau
2015-02-13 14:57 ` [PATCH v2 09/10] mac80211: reduce calculation costs of EWMA Thomas Huehn
2015-02-13 14:57 ` [PATCH v2 10/10] mac80211: add standard deviation to Minstrels throughput statistic Thomas Huehn
2015-02-25 21:00 ` [PATCH v2 0/10] Improve Minstrels & Minstrel-HTs common code base & statistics Bastian Bittorf
2015-02-25 21:18 ` Bastian Bittorf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150225211817.GC8189@medion.lan \
--to=bittorf@bluebottle.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.