From: Mike Snitzer <snitzer@redhat.com>
To: "Busch, Keith" <keith.busch@intel.com>
Cc: Jens Axboe <axboe@kernel.dk>,
jmoyer@redhat.com, shivakrishna.merla@netapp.com,
dm-devel@redhat.com, Bart Van Assche <bvanassche@acm.org>
Subject: Re: awful request merge results while simulating high IOPS multipath
Date: Wed, 25 Feb 2015 17:10:47 -0500 [thread overview]
Message-ID: <20150225221047.GA22281@redhat.com> (raw)
In-Reply-To: <B58D82457FDA0744A320A2FC5AC253B93BA8BF21@fmsmsx104.amr.corp.intel.com>
On Wed, Feb 25 2015 at 1:17pm -0500,
Busch, Keith <keith.busch@intel.com> wrote:
> Sorry, my reply was non sequitur to this thread. We don't do merging
> in NVMe.
NVMe may not but current dm-multipath's top-level queue will. And any
future blk-mq enabled dm-multipath (which I'm starting to look into now)
will need to also.
> Our first bottleneck appears to be the device mapper's single lock
> request queue.
Obviously if we switched dm-multipath over to blk-mq we'd eliminate
that. I'll see how things go and will share any changes I come up
with.
FYI, here is a related exchange Jens and I had on the LSF-only mailing
list:
On Tue, Feb 24 2015 at 1:43pm -0500,
Jens Axboe <axboe@kernel.dk> wrote:
> On 02/24/2015 10:37 AM, Mike Snitzer wrote:
>
> >I agree. I'd hate to be called up front to tap dance around some yet to
> >be analyzed issue. But discussing the best way to update multipath for
> >blk-mq devices is fair game.
> >
> >As is, the current blk-mq code doesn't have any IO scheduler so the
> >overall approach that DM multipath _attempts_ to take (namely leaning on
> >the elevator to create larger requests that are then balanced across the
> >underlying paths) is a non-starter.
>
> No it isn't, blk-mq still provides merging, the logic would very
> much be the same there... I think the crux of the problem is the way
> too frequent queue runs, that'd similarly be a problem on the blk-mq
> front.
>
> --
> Jens Axboe
>
next prev parent reply other threads:[~2015-02-25 22:10 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-24 16:44 [PATCH 0/4] dm: simplify request-based DM a bit and an RFC-like perf tweak Mike Snitzer
2015-02-24 16:44 ` [PATCH 1/4] dm: remove unnecessary wrapper around blk_lld_busy Mike Snitzer
2015-02-24 16:44 ` [PATCH 2/4] dm: remove request-based DM queue's lld_busy_fn hook Mike Snitzer
2015-02-24 16:44 ` [PATCH 3/4] dm: remove request-based logic from make_request_fn wrapper Mike Snitzer
2015-02-24 16:44 ` [RFC PATCH 4/4] dm: delay running the queue slightly during request completion Mike Snitzer
2015-02-24 16:51 ` Jens Axboe
2015-02-24 17:22 ` [RFC PATCH 4/4 v2] " Mike Snitzer
2015-02-24 17:52 ` Jens Axboe
2015-02-24 18:12 ` Mike Snitzer
2015-02-24 18:16 ` Jens Axboe
2015-02-24 18:32 ` Mike Snitzer
2015-02-25 0:56 ` awful request merge results while simulating high IOPS multipath Mike Snitzer
2015-02-25 4:14 ` Keith Busch
2015-02-25 15:11 ` Jens Axboe
2015-02-25 18:17 ` Busch, Keith
2015-02-25 22:10 ` Mike Snitzer [this message]
2015-02-25 23:57 ` Keith Busch
2015-02-26 0:11 ` Mike Snitzer
2015-02-26 0:28 ` Keith Busch
2015-02-25 4:38 ` FIXED! [was: awful request merge results while simulating high IOPS] multipath Mike Snitzer
2015-02-25 4:41 ` Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150225221047.GA22281@redhat.com \
--to=snitzer@redhat.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=dm-devel@redhat.com \
--cc=jmoyer@redhat.com \
--cc=keith.busch@intel.com \
--cc=shivakrishna.merla@netapp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.