From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Sebastian Reichel <sre@kernel.org>
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-input@vger.kernel.org, Jiri Kosina <jkosina@suse.cz>
Subject: Re: [PATCH v4 02/20] power_supply: Move run-time configuration to separate structure
Date: Wed, 25 Feb 2015 17:10:07 -0800 [thread overview]
Message-ID: <20150226011007.GA25965@dtor-ws> (raw)
In-Reply-To: <20150226003409.GA885@earth>
On Thu, Feb 26, 2015 at 01:34:09AM +0100, Sebastian Reichel wrote:
> Hi,
>
> On Mon, Feb 23, 2015 at 12:47:23PM +0100, Krzysztof Kozlowski wrote:
> > Add new structure 'power_supply_config' for holding run-time
> > initialization data like of_node, supplies and private driver data.
> >
> > The power_supply_register() function is changed so all power supply
> > drivers need updating.
> >
> > When registering the power supply this new 'power_supply_config' should be
> > used instead of directly initializing 'struct power_supply'. This allows
> > changing the ownership of power_supply structure from driver to the
> > power supply core in next patches.
> >
> > When a driver does not use of_node or supplies then it should use NULL
> > as config. If driver uses of_node or supplies then it should allocate
> > config on stack and initialize it with proper values.
> >
> > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> > Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> > Acked-by: Pavel Machek <pavel@ucw.cz>
> >
> > [for the nvec part]
> > Reviewed-by: Marc Dietrich <marvin24@gmx.de>
> >
> > [for drivers/platform/x86/compal-laptop.c]
> > Reviewed-by: Darren Hart <dvhart@linux.intel.com>
> > ---
> > drivers/acpi/ac.c | 2 +-
> > drivers/acpi/battery.c | 3 ++-
> > drivers/acpi/sbs.c | 4 ++--
> > drivers/hid/hid-input.c | 2 +-
> > drivers/hid/hid-sony.c | 2 +-
> > drivers/hid/hid-wiimote-modules.c | 2 +-
> > drivers/hid/wacom_sys.c | 5 +++--
> > drivers/platform/x86/compal-laptop.c | 2 +-
> > drivers/power/[...] | lots of changes
> > drivers/staging/nvec/nvec_power.c | 7 ++++---
> > include/linux/power_supply.h | 16 ++++++++++++++--
> > 67 files changed, 211 insertions(+), 158 deletions(-)
>
> I would like to merge this via the power supply tree.
>
> Rafael, Dmitry, are you ok with this change?
Hmm, I do not see anything affecting input here, you want Jiri for HID I
guess...
--
Dmitry
next prev parent reply other threads:[~2015-02-26 1:10 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-23 11:47 [PATCH v4 00/20] power_supply: Allow safe usage of power supply Krzysztof Kozlowski
2015-02-23 11:47 ` Krzysztof Kozlowski
2015-02-23 11:47 ` Krzysztof Kozlowski
[not found] ` <1424692061-30624-1-git-send-email-k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-02-23 11:47 ` [PATCH v4 01/20] power_supply: Add driver private data Krzysztof Kozlowski
2015-02-23 11:47 ` Krzysztof Kozlowski
2015-02-23 11:47 ` Krzysztof Kozlowski
2015-02-23 11:47 ` [PATCH v4 02/20] power_supply: Move run-time configuration to separate structure Krzysztof Kozlowski
2015-02-23 11:47 ` Krzysztof Kozlowski
2015-02-23 11:47 ` Krzysztof Kozlowski
2015-02-26 0:34 ` Sebastian Reichel
2015-02-26 1:10 ` Dmitry Torokhov [this message]
2015-02-26 1:58 ` Sebastian Reichel
2015-02-23 11:47 ` [PATCH v4 03/20] power_supply: Add API for safe access of power supply function attrs Krzysztof Kozlowski
2015-02-23 11:47 ` Krzysztof Kozlowski
2015-02-23 11:47 ` Krzysztof Kozlowski
2015-02-23 11:47 ` [PATCH v4 04/20] power_supply: sysfs: Use power_supply_*() API for accessing " Krzysztof Kozlowski
2015-02-23 11:47 ` Krzysztof Kozlowski
2015-02-23 11:47 ` Krzysztof Kozlowski
2015-02-23 11:47 ` [PATCH v4 05/20] power_supply: 88pm860x_charger: " Krzysztof Kozlowski
2015-02-23 11:47 ` Krzysztof Kozlowski
2015-02-23 11:47 ` Krzysztof Kozlowski
2015-02-23 11:47 ` [PATCH v4 06/20] power_supply: ab8500: " Krzysztof Kozlowski
2015-02-23 11:47 ` Krzysztof Kozlowski
2015-02-23 11:47 ` Krzysztof Kozlowski
2015-02-23 11:47 ` [PATCH v4 07/20] mfd: " Krzysztof Kozlowski
2015-02-23 11:47 ` Krzysztof Kozlowski
2015-02-23 11:47 ` Krzysztof Kozlowski
2015-02-23 11:47 ` [PATCH v4 08/20] power_supply: apm_power: " Krzysztof Kozlowski
2015-02-23 11:47 ` Krzysztof Kozlowski
2015-02-23 11:47 ` Krzysztof Kozlowski
2015-02-23 11:47 ` [PATCH v4 09/20] power_supply: bq2415x_charger: " Krzysztof Kozlowski
2015-02-23 11:47 ` Krzysztof Kozlowski
2015-02-23 11:47 ` Krzysztof Kozlowski
2015-02-23 11:47 ` [PATCH v4 10/20] power_supply: charger-manager: " Krzysztof Kozlowski
2015-02-23 11:47 ` Krzysztof Kozlowski
2015-02-23 11:47 ` Krzysztof Kozlowski
2015-02-23 11:47 ` [PATCH v4 11/20] power_supply: Change ownership from driver to core Krzysztof Kozlowski
2015-02-23 11:47 ` Krzysztof Kozlowski
2015-02-26 0:45 ` Sebastian Reichel
2015-02-26 0:45 ` Sebastian Reichel
2015-02-26 0:45 ` Sebastian Reichel
2015-02-26 6:14 ` Darren Hart
2015-02-26 6:14 ` Darren Hart
2015-02-26 6:14 ` Darren Hart
2015-02-26 11:28 ` Krzysztof Kozlowski
2015-02-26 11:31 ` Krzysztof Kozlowski
2015-03-03 16:44 ` Darren Hart
2015-02-26 9:30 ` Krzysztof Kozlowski
2015-02-26 9:30 ` Krzysztof Kozlowski
2015-02-26 9:30 ` Krzysztof Kozlowski
2015-02-26 8:24 ` Lee Jones
2015-02-26 8:24 ` Lee Jones
2015-02-26 8:24 ` Lee Jones
2015-02-23 11:47 ` [PATCH v4 12/20] power_supply: Add power_supply_put for decrementing device reference counter Krzysztof Kozlowski
2015-02-23 11:47 ` Krzysztof Kozlowski
2015-02-23 11:47 ` Krzysztof Kozlowski
2015-02-23 11:47 ` [PATCH v4 13/20] power_supply: Increment power supply use counter when obtaining references Krzysztof Kozlowski
2015-02-23 11:47 ` Krzysztof Kozlowski
2015-02-23 11:47 ` Krzysztof Kozlowski
2015-02-23 11:47 ` [PATCH v4 14/20] power_supply: charger-manager: Decrement the power supply's device reference counter Krzysztof Kozlowski
2015-02-23 11:47 ` Krzysztof Kozlowski
2015-02-23 11:47 ` Krzysztof Kozlowski
2015-02-23 11:47 ` [PATCH v4 15/20] x86/olpc/xo1/sci: Use newly added power_supply_put API Krzysztof Kozlowski
2015-02-23 11:47 ` Krzysztof Kozlowski
2015-02-23 11:47 ` Krzysztof Kozlowski
2015-02-23 11:47 ` [PATCH v4 16/20] x86/olpc/xo15/sci: " Krzysztof Kozlowski
2015-02-23 11:47 ` Krzysztof Kozlowski
2015-02-23 11:47 ` Krzysztof Kozlowski
2015-02-23 11:47 ` [PATCH v4 17/20] power_supply: 88pm860x_charger: Decrement the power supply's device reference counter Krzysztof Kozlowski
2015-02-23 11:47 ` Krzysztof Kozlowski
2015-02-23 11:47 ` Krzysztof Kozlowski
2015-02-23 11:47 ` [PATCH v4 18/20] power_supply: bq2415x_charger: " Krzysztof Kozlowski
2015-02-23 11:47 ` Krzysztof Kozlowski
2015-02-23 11:47 ` Krzysztof Kozlowski
2015-02-23 11:47 ` [PATCH v4 19/20] mfd: ab8500: " Krzysztof Kozlowski
2015-02-23 11:47 ` Krzysztof Kozlowski
2015-02-23 11:47 ` Krzysztof Kozlowski
2015-02-23 11:47 ` [PATCH v4 20/20] arm: mach-pxa: " Krzysztof Kozlowski
2015-02-23 11:47 ` Krzysztof Kozlowski
2015-02-23 11:47 ` Krzysztof Kozlowski
2015-02-23 22:18 ` [PATCH v4 00/20] power_supply: Allow safe usage of power supply Pavel Machek
2015-02-23 22:18 ` Pavel Machek
2015-02-23 22:18 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150226011007.GA25965@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=jkosina@suse.cz \
--cc=k.kozlowski@samsung.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.