From mboxrd@z Thu Jan 1 00:00:00 1970 From: boris.brezillon@free-electrons.com (Boris Brezillon) Date: Thu, 26 Feb 2015 14:21:20 +0100 Subject: [PATCH] drm: atmel-hlcdc: remove clock polarity from crtc driver In-Reply-To: <1424886291-15747-1-git-send-email-nicolas.ferre@atmel.com> References: <1424886291-15747-1-git-send-email-nicolas.ferre@atmel.com> Message-ID: <20150226142120.71fa7fe2@bbrezillon> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, 25 Feb 2015 18:44:51 +0100 Nicolas Ferre wrote: > Remove this configuration bit in crtc driver as the rising edge clock is widely > used. Applied to drm-atmel-hlcdc-fixes. Thanks, Boris > > Signed-off-by: Boris BREZILLON > Signed-off-by: Nicolas Ferre > --- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c > index 0409b907de5d..b3e3068c6ec0 100644 > --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c > +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c > @@ -153,7 +153,7 @@ static int atmel_hlcdc_crtc_mode_set(struct drm_crtc *c, > (adj->crtc_hdisplay - 1) | > ((adj->crtc_vdisplay - 1) << 16)); > > - cfg = ATMEL_HLCDC_CLKPOL; > + cfg = 0; > > prate = clk_get_rate(crtc->dc->hlcdc->sys_clk); > mode_rate = mode->crtc_clock * 1000; -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH] drm: atmel-hlcdc: remove clock polarity from crtc driver Date: Thu, 26 Feb 2015 14:21:20 +0100 Message-ID: <20150226142120.71fa7fe2@bbrezillon> References: <1424886291-15747-1-git-send-email-nicolas.ferre@atmel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.free-electrons.com (down.free-electrons.com [37.187.137.238]) by gabe.freedesktop.org (Postfix) with ESMTP id 4B4A16E7C2 for ; Thu, 26 Feb 2015 05:21:24 -0800 (PST) In-Reply-To: <1424886291-15747-1-git-send-email-nicolas.ferre@atmel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Nicolas Ferre Cc: Alexandre Belloni , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCAyNSBGZWIgMjAxNSAxODo0NDo1MSArMDEwMApOaWNvbGFzIEZlcnJlIDxuaWNvbGFz LmZlcnJlQGF0bWVsLmNvbT4gd3JvdGU6Cgo+IFJlbW92ZSB0aGlzIGNvbmZpZ3VyYXRpb24gYml0 IGluIGNydGMgZHJpdmVyIGFzIHRoZSByaXNpbmcgZWRnZSBjbG9jayBpcyB3aWRlbHkKPiB1c2Vk LgoKQXBwbGllZCB0byBkcm0tYXRtZWwtaGxjZGMtZml4ZXMuCgpUaGFua3MsCgpCb3JpcwoKPiAK PiBTaWduZWQtb2ZmLWJ5OiBCb3JpcyBCUkVaSUxMT04gPGJvcmlzLmJyZXppbGxvbkBmcmVlLWVs ZWN0cm9ucy5jb20+Cj4gU2lnbmVkLW9mZi1ieTogTmljb2xhcyBGZXJyZSA8bmljb2xhcy5mZXJy ZUBhdG1lbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9hdG1lbC1obGNkYy9hdG1lbF9o bGNkY19jcnRjLmMgfCAyICstCj4gIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBk ZWxldGlvbigtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYXRtZWwtaGxjZGMv YXRtZWxfaGxjZGNfY3J0Yy5jIGIvZHJpdmVycy9ncHUvZHJtL2F0bWVsLWhsY2RjL2F0bWVsX2hs Y2RjX2NydGMuYwo+IGluZGV4IDA0MDliOTA3ZGU1ZC4uYjNlMzA2OGM2ZWMwIDEwMDY0NAo+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9hdG1lbC1obGNkYy9hdG1lbF9obGNkY19jcnRjLmMKPiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vYXRtZWwtaGxjZGMvYXRtZWxfaGxjZGNfY3J0Yy5jCj4gQEAgLTE1 Myw3ICsxNTMsNyBAQCBzdGF0aWMgaW50IGF0bWVsX2hsY2RjX2NydGNfbW9kZV9zZXQoc3RydWN0 IGRybV9jcnRjICpjLAo+ICAJCSAgICAgKGFkai0+Y3J0Y19oZGlzcGxheSAtIDEpIHwKPiAgCQkg ICAgICgoYWRqLT5jcnRjX3ZkaXNwbGF5IC0gMSkgPDwgMTYpKTsKPiAgCj4gLQljZmcgPSBBVE1F TF9ITENEQ19DTEtQT0w7Cj4gKwljZmcgPSAwOwo+ICAKPiAgCXByYXRlID0gY2xrX2dldF9yYXRl KGNydGMtPmRjLT5obGNkYy0+c3lzX2Nsayk7Cj4gIAltb2RlX3JhdGUgPSBtb2RlLT5jcnRjX2Ns b2NrICogMTAwMDsKCgoKLS0gCkJvcmlzIEJyZXppbGxvbiwgRnJlZSBFbGVjdHJvbnMKRW1iZWRk ZWQgTGludXggYW5kIEtlcm5lbCBlbmdpbmVlcmluZwpodHRwOi8vZnJlZS1lbGVjdHJvbnMuY29t Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZl bCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932372AbbBZNV0 (ORCPT ); Thu, 26 Feb 2015 08:21:26 -0500 Received: from down.free-electrons.com ([37.187.137.238]:44054 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753439AbbBZNVX (ORCPT ); Thu, 26 Feb 2015 08:21:23 -0500 Date: Thu, 26 Feb 2015 14:21:20 +0100 From: Boris Brezillon To: Nicolas Ferre Cc: , , , Alexandre Belloni , Subject: Re: [PATCH] drm: atmel-hlcdc: remove clock polarity from crtc driver Message-ID: <20150226142120.71fa7fe2@bbrezillon> In-Reply-To: <1424886291-15747-1-git-send-email-nicolas.ferre@atmel.com> References: <1424886291-15747-1-git-send-email-nicolas.ferre@atmel.com> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 25 Feb 2015 18:44:51 +0100 Nicolas Ferre wrote: > Remove this configuration bit in crtc driver as the rising edge clock is widely > used. Applied to drm-atmel-hlcdc-fixes. Thanks, Boris > > Signed-off-by: Boris BREZILLON > Signed-off-by: Nicolas Ferre > --- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c > index 0409b907de5d..b3e3068c6ec0 100644 > --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c > +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c > @@ -153,7 +153,7 @@ static int atmel_hlcdc_crtc_mode_set(struct drm_crtc *c, > (adj->crtc_hdisplay - 1) | > ((adj->crtc_vdisplay - 1) << 16)); > > - cfg = ATMEL_HLCDC_CLKPOL; > + cfg = 0; > > prate = clk_get_rate(crtc->dc->hlcdc->sys_clk); > mode_rate = mode->crtc_clock * 1000; -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com