[PATCH v2] Staging: vt6655: changed C99 // comments

[PATCH v2] Staging: vt6655: changed C99 // comments

[Hatice ERTÜRK]

// erased and replace it with /**/ used.
Error found with checkpatch.pl

Signed-off-by: Hatice ERTURK <haticeerturk27@gmail.com>
---
v2:
*Some /**/ deleted.A row in a single comment line was made.Added a space between the ; and the /*.
---
 drivers/staging/vt6655/rf.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/vt6655/rf.c b/drivers/staging/vt6655/rf.c
index 0b58927..d5fae3e 100644
--- a/drivers/staging/vt6655/rf.c
+++ b/drivers/staging/vt6655/rf.c
@@ -438,13 +438,13 @@ static bool s_bAL7230Init(struct vnt_private *priv)
 	MACvWordRegBitsOn(dwIoBase, MAC_REG_SOFTPWRCTL, SOFTPWRCTL_SWPE3);
 
 	/* Calibration */
-	MACvTimer0MicroSDelay(dwIoBase, 150);/* 150us */
+	MACvTimer0MicroSDelay(dwIoBase, 150); /* 150us */
 	/* TXDCOC:active, RCK:disable */
 	bResult &= IFRFbWriteEmbedded(priv, (0x9ABA8F00+(BY_AL7230_REG_LEN<<3)+IFREGCTL_REGW));
-	MACvTimer0MicroSDelay(dwIoBase, 30);/* 30us */
+	MACvTimer0MicroSDelay(dwIoBase, 30); /* 30us */
 	/* TXDCOC:disable, RCK:active */
 	bResult &= IFRFbWriteEmbedded(priv, (0x3ABA8F00+(BY_AL7230_REG_LEN<<3)+IFREGCTL_REGW));
-	MACvTimer0MicroSDelay(dwIoBase, 30);/* 30us */
+	MACvTimer0MicroSDelay(dwIoBase, 30); /* 30us */
 	/* TXDCOC:disable, RCK:disable */
 	bResult &= IFRFbWriteEmbedded(priv, dwAL7230InitTable[CB_AL7230_INIT_SEQ-1]);
 
-- 
1.9.1

Re: [Outreachy kernel] [PATCH v2] Staging: vt6655: changed C99 // comments

[Julia Lawall]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 2280 bytes --]

On Sat, 21 Feb 2015, Hatice ERTÜRK wrote:

> // erased and replace it with /**/ used.
> Error found with checkpatch.pl
> 
> Signed-off-by: Hatice ERTURK <haticeerturk27@gmail.com>
> ---
> v2:
> *Some /**/ deleted.A row in a single comment line was made.Added a space between the ; and the /*.

Looks better.  The * at the beginning of the line does not seem necessary.  
When you put punctuation (comma, period, etc) put at least one space after 
it.

You don't have to send a new version for these issues, because the text is 
below the line.  Just remember for next time.

julia

> ---
>  drivers/staging/vt6655/rf.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/vt6655/rf.c b/drivers/staging/vt6655/rf.c
> index 0b58927..d5fae3e 100644
> --- a/drivers/staging/vt6655/rf.c
> +++ b/drivers/staging/vt6655/rf.c
> @@ -438,13 +438,13 @@ static bool s_bAL7230Init(struct vnt_private *priv)
>  	MACvWordRegBitsOn(dwIoBase, MAC_REG_SOFTPWRCTL, SOFTPWRCTL_SWPE3);
>  
>  	/* Calibration */
> -	MACvTimer0MicroSDelay(dwIoBase, 150);/* 150us */
> +	MACvTimer0MicroSDelay(dwIoBase, 150); /* 150us */
>  	/* TXDCOC:active, RCK:disable */
>  	bResult &= IFRFbWriteEmbedded(priv, (0x9ABA8F00+(BY_AL7230_REG_LEN<<3)+IFREGCTL_REGW));
> -	MACvTimer0MicroSDelay(dwIoBase, 30);/* 30us */
> +	MACvTimer0MicroSDelay(dwIoBase, 30); /* 30us */
>  	/* TXDCOC:disable, RCK:active */
>  	bResult &= IFRFbWriteEmbedded(priv, (0x3ABA8F00+(BY_AL7230_REG_LEN<<3)+IFREGCTL_REGW));
> -	MACvTimer0MicroSDelay(dwIoBase, 30);/* 30us */
> +	MACvTimer0MicroSDelay(dwIoBase, 30); /* 30us */
>  	/* TXDCOC:disable, RCK:disable */
>  	bResult &= IFRFbWriteEmbedded(priv, dwAL7230InitTable[CB_AL7230_INIT_SEQ-1]);
>  
> -- 
> 1.9.1
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1424472008-9544-1-git-send-email-haticeerturk27%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
> 

Re: [Outreachy kernel] [PATCH v2] Staging: vt6655: changed C99 // comments

[Greg KH]

On Sat, Feb 21, 2015 at 12:40:08AM +0200, Hatice ERT�RK wrote:
> // erased and replace it with /**/ used.
> Error found with checkpatch.pl
> 
> Signed-off-by: Hatice ERTURK <haticeerturk27@gmail.com>
> ---
> v2:
> *Some /**/ deleted.A row in a single comment line was made.Added a space between the ; and the /*.
> ---
>  drivers/staging/vt6655/rf.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/vt6655/rf.c b/drivers/staging/vt6655/rf.c
> index 0b58927..d5fae3e 100644
> --- a/drivers/staging/vt6655/rf.c
> +++ b/drivers/staging/vt6655/rf.c
> @@ -438,13 +438,13 @@ static bool s_bAL7230Init(struct vnt_private *priv)
>  	MACvWordRegBitsOn(dwIoBase, MAC_REG_SOFTPWRCTL, SOFTPWRCTL_SWPE3);
>  
>  	/* Calibration */
> -	MACvTimer0MicroSDelay(dwIoBase, 150);/* 150us */
> +	MACvTimer0MicroSDelay(dwIoBase, 150); /* 150us */
>  	/* TXDCOC:active, RCK:disable */
>  	bResult &= IFRFbWriteEmbedded(priv, (0x9ABA8F00+(BY_AL7230_REG_LEN<<3)+IFREGCTL_REGW));
> -	MACvTimer0MicroSDelay(dwIoBase, 30);/* 30us */
> +	MACvTimer0MicroSDelay(dwIoBase, 30); /* 30us */
>  	/* TXDCOC:disable, RCK:active */
>  	bResult &= IFRFbWriteEmbedded(priv, (0x3ABA8F00+(BY_AL7230_REG_LEN<<3)+IFREGCTL_REGW));
> -	MACvTimer0MicroSDelay(dwIoBase, 30);/* 30us */
> +	MACvTimer0MicroSDelay(dwIoBase, 30); /* 30us */
>  	/* TXDCOC:disable, RCK:disable */
>  	bResult &= IFRFbWriteEmbedded(priv, dwAL7230InitTable[CB_AL7230_INIT_SEQ-1]);
>  
> -- 
> 1.9.1

This also doesn't apply, please use my latest kernel tree.

thanks,

greg k-h