[PATCH] Staging: vt6655: { retrieved upper row

[PATCH] Staging: vt6655: { retrieved upper row

[Hatice ERTÜRK]

That open brace { should be on the previous line.
This Error found with checkpatch.pl

Signed-off-by: Hatice ERTURK <haticeerturk27@gmail.com>
---
 drivers/staging/vt6655/card.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
index a079640..e77a5f6 100644
--- a/drivers/staging/vt6655/card.c
+++ b/drivers/staging/vt6655/card.c
@@ -68,8 +68,8 @@
 
 /*---------------------  Static Variables  --------------------------*/
 
-static const unsigned short cwRXBCNTSFOff[MAX_RATE] =
-{17, 17, 17, 17, 34, 23, 17, 11, 8, 5, 4, 3};
+static const unsigned short cwRXBCNTSFOff[MAX_RATE] = {
+17, 17, 17, 17, 34, 23, 17, 11, 8, 5, 4, 3};
 
 /*---------------------  Static Functions  --------------------------*/
 
-- 
1.9.1

Re: [Outreachy kernel] [PATCH] Staging: vt6655: { retrieved upper row

[Julia Lawall]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1603 bytes --]

On Sat, 21 Feb 2015, Hatice ERTÜRK wrote:

> That open brace { should be on the previous line.
> This Error found with checkpatch.pl

I think the { is ok where it is in this code, but I'm not an expert on 
this issue...

{ retrived upper row is not easy to understand.  Perhaps Move { up one 
line.

julia

> Signed-off-by: Hatice ERTURK <haticeerturk27@gmail.com>
> ---
>  drivers/staging/vt6655/card.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
> index a079640..e77a5f6 100644
> --- a/drivers/staging/vt6655/card.c
> +++ b/drivers/staging/vt6655/card.c
> @@ -68,8 +68,8 @@
>  
>  /*---------------------  Static Variables  --------------------------*/
>  
> -static const unsigned short cwRXBCNTSFOff[MAX_RATE] =
> -{17, 17, 17, 17, 34, 23, 17, 11, 8, 5, 4, 3};
> +static const unsigned short cwRXBCNTSFOff[MAX_RATE] = {
> +17, 17, 17, 17, 34, 23, 17, 11, 8, 5, 4, 3};
>  
>  /*---------------------  Static Functions  --------------------------*/
>  
> -- 
> 1.9.1
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1424550280-22040-1-git-send-email-haticeerturk27%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
> 

Re: [Outreachy kernel] [PATCH] Staging: vt6655: { retrieved upper row

[Hatice ERTÜRK]

[-- Attachment #1.1: Type: text/plain, Size: 101 bytes --]

I think the { is ok but the error  there was given. I didn't think of other 
ways.So I've done that.

[-- Attachment #1.2: Type: text/html, Size: 462 bytes --]

Re: [Outreachy kernel] [PATCH] Staging: vt6655: { retrieved upper row

[Julia Lawall]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 894 bytes --]

On Sat, 21 Feb 2015, Hatice ERTÜRK wrote:

> I think the { is ok but the error  there was given. I didn't think of other
> ways.So I've done that.

Check patch is not always correct.  It uses some regular expressions to 
figure out what the different kinds of code might be, but it may be that 
it has misinterpreted something in this case.

julia

> 
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/72ff878e-070b-4eb8-9849-
> f823194bb84c%40googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
> 
> 

Re: [Outreachy kernel] [PATCH] Staging: vt6655: { retrieved upper row

[Greg KH]

On Sat, Feb 21, 2015 at 10:24:40PM +0200, Hatice ERT�RK wrote:
> That open brace { should be on the previous line.
> This Error found with checkpatch.pl
> 
> Signed-off-by: Hatice ERTURK <haticeerturk27@gmail.com>
> ---
>  drivers/staging/vt6655/card.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
> index a079640..e77a5f6 100644
> --- a/drivers/staging/vt6655/card.c
> +++ b/drivers/staging/vt6655/card.c
> @@ -68,8 +68,8 @@
>  
>  /*---------------------  Static Variables  --------------------------*/
>  
> -static const unsigned short cwRXBCNTSFOff[MAX_RATE] =
> -{17, 17, 17, 17, 34, 23, 17, 11, 8, 5, 4, 3};
> +static const unsigned short cwRXBCNTSFOff[MAX_RATE] = {
> +17, 17, 17, 17, 34, 23, 17, 11, 8, 5, 4, 3};
>  
>  /*---------------------  Static Functions  --------------------------*/
>  

This too doesn't apply :(