Re: [Outreachy kernel] [PATCH v2 2/2] Staging: i2o: Corrected code indentation

[Greg KH <gregkh@linuxfoundation.org>]

On Thu, Feb 26, 2015 at 01:12:19AM +0200, aybuke ozdemir wrote:
> WARNING: suspect code indent for conditional statements(8,12)
> spaces are converting to tabs suspect code indent is deleted.
> That was found by running checkpatch.pl
> 
> Signed-off-by: aybuke ozdemir <aybuke.147@gmail.com>
> ---
>  drivers/staging/i2o/device.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/i2o/device.c b/drivers/staging/i2o/device.c
> index e47496c..cd6da9c 100644
> --- a/drivers/staging/i2o/device.c
> +++ b/drivers/staging/i2o/device.c
> @@ -260,10 +260,10 @@ static int i2o_device_add(struct i2o_controller *c, i2o_lct_entry *entry)
>  
>  	/* create user entries referring to this device */
>  	list_for_each_entry(tmp, &c->devices, list)
> -	    if ((tmp->lct_data.user_tid == i2o_dev->lct_data.tid)
> -		&& (tmp != i2o_dev)) {
> -		rc = sysfs_create_link(&tmp->device.kobj,
> -				       &i2o_dev->device.kobj, "user");
> +		if ((tmp->lct_data.user_tid == i2o_dev->lct_data.tid)
> +						&& (tmp != i2o_dev)) {
> +			rc = sysfs_create_link(&tmp->device.kobj,
> +						&i2o_dev->device.kobj, "user");
>  		if (rc)
>  			goto rmlink1;

Something is still wrong with the indentation here, sorry.  Look at the
{ placement.

thanks,

greg k-h