[PATCH] staging: media: parport: remove unused variable

[PATCH] staging: media: parport: remove unused variable

[Aya Mahfouz]

This patch uses the following coccinelle script to remove
a variable that was simply used to store the return
value of a function call before returning it:

@@
identifier len,f;
@@

-int len;
 ... when != len
     when strict
-len = 
+return 
	f(...);
-return len;

Signed-off-by: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>
---
 drivers/staging/media/parport/pms.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/staging/media/parport/pms.c b/drivers/staging/media/parport/pms.c
index e6b4975..56e1d1f 100644
--- a/drivers/staging/media/parport/pms.c
+++ b/drivers/staging/media/parport/pms.c
@@ -875,10 +875,7 @@ static ssize_t pms_read(struct file *file, char __user *buf,
 		    size_t count, loff_t *ppos)
 {
 	struct pms *dev = video_drvdata(file);
-	int len;
-
-	len = pms_capture(dev, buf, (dev->depth == 15), count);
-	return len;
+	return pms_capture(dev, buf, (dev->depth == 15), count);
 }
 
 static unsigned int pms_poll(struct file *file, struct poll_table_struct *wait)
-- 
1.9.3

Re: [Outreachy kernel] [PATCH] staging: media: parport: remove unused variable

[Julia Lawall]

Acked-by: Julia Lawall <julia.lawall@lip6.fr>

On Wed, 18 Feb 2015, Aya Mahfouz wrote:

> This patch uses the following coccinelle script to remove
> a variable that was simply used to store the return
> value of a function call before returning it:
> 
> @@
> identifier len,f;
> @@
> 
> -int len;
>  ... when != len
>      when strict
> -len = 
> +return 
> 	f(...);
> -return len;
> 
> Signed-off-by: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>
> ---
>  drivers/staging/media/parport/pms.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/media/parport/pms.c b/drivers/staging/media/parport/pms.c
> index e6b4975..56e1d1f 100644
> --- a/drivers/staging/media/parport/pms.c
> +++ b/drivers/staging/media/parport/pms.c
> @@ -875,10 +875,7 @@ static ssize_t pms_read(struct file *file, char __user *buf,
>  		    size_t count, loff_t *ppos)
>  {
>  	struct pms *dev = video_drvdata(file);
> -	int len;
> -
> -	len = pms_capture(dev, buf, (dev->depth == 15), count);
> -	return len;
> +	return pms_capture(dev, buf, (dev->depth == 15), count);
>  }
>  
>  static unsigned int pms_poll(struct file *file, struct poll_table_struct *wait)
> -- 
> 1.9.3
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20150218003417.GA16982%40localhost.localdomain.
> For more options, visit https://groups.google.com/d/optout.
> 

Re: [Outreachy kernel] [PATCH] staging: media: parport: remove unused variable

[Greg KH]

On Wed, Feb 18, 2015 at 02:34:17AM +0200, Aya Mahfouz wrote:
> This patch uses the following coccinelle script to remove
> a variable that was simply used to store the return
> value of a function call before returning it:
> 
> @@
> identifier len,f;
> @@
> 
> -int len;
>  ... when != len
>      when strict
> -len = 
> +return 
> 	f(...);
> -return len;
> 
> Signed-off-by: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>
> Acked-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
>  drivers/staging/media/parport/pms.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)

This file is no longer in Linus's tree :(