From: Greg KH <gregkh@linuxfoundation.org>
To: Katie Dunne <kdunne@mail.ccsf.edu>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH] Staging: media: mn88472: Match alignment with open parenthesis
Date: Thu, 26 Feb 2015 10:53:48 -0800 [thread overview]
Message-ID: <20150226185348.GA17122@kroah.com> (raw)
In-Reply-To: <20150219163250.GA29556@katie-Inspiron-5748>
On Thu, Feb 19, 2015 at 08:32:51AM -0800, Katie Dunne wrote:
> This patch fixes the checkpatch.pl Check:
> CHECK: Alignment should match open parenthesis
>
> Used tabs and spaces in 8 instances to align with open parenthesis
>
> Signed-off-by: Katie Dunne <kdunne@mail.ccsf.edu>
> ---
> drivers/staging/media/mn88472/mn88472.c | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/staging/media/mn88472/mn88472.c b/drivers/staging/media/mn88472/mn88472.c
> index 52de8f8..b8e43ed 100644
> --- a/drivers/staging/media/mn88472/mn88472.c
> +++ b/drivers/staging/media/mn88472/mn88472.c
> @@ -17,7 +17,7 @@
> #include "mn88472_priv.h"
>
> static int mn88472_get_tune_settings(struct dvb_frontend *fe,
> - struct dvb_frontend_tune_settings *s)
> + struct dvb_frontend_tune_settings *s)
> {
> s->min_delay_ms = 400;
> return 0;
> @@ -33,9 +33,9 @@ static int mn88472_set_frontend(struct dvb_frontend *fe)
> u8 delivery_system_val, if_val[3], bw_val[7], bw_val2;
>
> dev_dbg(&client->dev,
> - "delivery_system=%d modulation=%d frequency=%d symbol_rate=%d inversion=%d\n",
> - c->delivery_system, c->modulation,
> - c->frequency, c->symbol_rate, c->inversion);
> + "delivery_system=%d modulation=%d frequency=%d symbol_rate=%d inversion=%d\n",
> + c->delivery_system, c->modulation,
> + c->frequency, c->symbol_rate, c->inversion);
>
> if (!dev->warm) {
> ret = -EAGAIN;
> @@ -113,7 +113,7 @@ static int mn88472_set_frontend(struct dvb_frontend *fe)
> break;
> default:
> dev_err(&client->dev, "IF frequency %d not supported\n",
> - if_frequency);
> + if_frequency);
> ret = -EINVAL;
> goto err;
> }
> @@ -277,12 +277,12 @@ static int mn88472_init(struct dvb_frontend *fe)
> ret = request_firmware(&fw, fw_file, &client->dev);
> if (ret) {
> dev_err(&client->dev, "firmare file '%s' not found\n",
> - fw_file);
> + fw_file);
> goto err;
> }
>
> dev_info(&client->dev, "downloading firmware from file '%s'\n",
> - fw_file);
> + fw_file);
>
> ret = regmap_write(dev->regmap[0], 0xf5, 0x03);
> if (ret)
> @@ -295,10 +295,10 @@ static int mn88472_init(struct dvb_frontend *fe)
> len = (dev->i2c_wr_max - 1);
>
> ret = regmap_bulk_write(dev->regmap[0], 0xf6,
> - &fw->data[fw->size - remaining], len);
> + &fw->data[fw->size - remaining], len);
> if (ret) {
> dev_err(&client->dev,
> - "firmware download failed=%d\n", ret);
> + "firmware download failed=%d\n", ret);
> goto err;
> }
> }
> @@ -384,7 +384,7 @@ static struct dvb_frontend_ops mn88472_ops = {
> };
>
> static int mn88472_probe(struct i2c_client *client,
> - const struct i2c_device_id *id)
> + const struct i2c_device_id *id)
> {
> struct mn88472_config *config = client->dev.platform_data;
> struct mn88472_dev *dev;
> --
> 1.9.1
This patch fails to apply to my tree for some reason. Can you please
refresh it and resend?
thanks,
greg k-h
prev parent reply other threads:[~2015-02-26 18:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-19 16:32 [PATCH] Staging: media: mn88472: Match alignment with open parenthesis Katie Dunne
2015-02-26 18:53 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150226185348.GA17122@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=kdunne@mail.ccsf.edu \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.