Re: [Outreachy kernel] [PATCH 2/2] Staging: rtl8188eu: Eliminate use of _init_timer

[Greg KH <gregkh@linuxfoundation.org>]

On Thu, Feb 26, 2015 at 11:42:34AM +0530, Vaishali Thakkar wrote:
> This patch introduces the use of API function setup_timer
> instead of driver specific function _init_timer as it is
> the preferred and standard way to setup and set the timer.
> Also, definition of function _init_timer is removed as it
> is no longer needed after this change.
> 
> Here, some of cases are handled using Coccinelle and
> semantic patch used for this is as follows:
> 
> @@ expression x, y; identifier a, b;@@
> 
> - _init_timer (&x, y, a, b);
> + setup_timer (&x, a, (unsigned long)b);
> 
> Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
> ---
> v1: Here, this patch has two line over 80 characters as
>     limiting them to 80 characters does not make code look
>     good and readable.
> 
>  drivers/staging/rtl8188eu/core/rtw_led.c          |  3 ++-
>  drivers/staging/rtl8188eu/core/rtw_pwrctrl.c      |  2 +-
>  drivers/staging/rtl8188eu/core/rtw_recv.c         |  2 +-
>  drivers/staging/rtl8188eu/include/osdep_service.h |  9 ---------
>  drivers/staging/rtl8188eu/os_dep/mlme_linux.c     | 18 ++++++++++++------
>  drivers/staging/rtl8188eu/os_dep/recv_linux.c     |  4 +++-
>  6 files changed, 19 insertions(+), 19 deletions(-)

Due to other changes in my tree, this patch no longer applies.  Can you
please redo it against my staging-testing branch of staging.git and
resend?

thanks,

greg k-h