From: Greg KH <gregkh@linuxfoundation.org>
To: Navya Sri Nizamkari <navyasri.tech@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH v2 1/4] staging: rtl8192u: Convert from printk into netdev_dbg or pr_dbg
Date: Thu, 26 Feb 2015 13:43:49 -0800 [thread overview]
Message-ID: <20150226214349.GA6995@kroah.com> (raw)
In-Reply-To: <faf65006e6915dfb3539058d59019502e805e7cc.1424622240.git.navyasri.tech@gmail.com>
On Sun, Feb 22, 2015 at 10:06:04PM +0530, Navya Sri Nizamkari wrote:
> As this is a network driver file, convert printk(KERN_DEBUG.. ) to
> netdev_dbg if the calling function has arguments to support it else
> to pr_dbg , to fix the checkpatch.pl warning:
>
> WARNING: Prefer netdev_dbg(netdev, ... then dev_dbg(dev, ... then
> pr_debug(... to printk(KERN_DEBUG ...
>
> Signed-off-by: Navya Sri Nizamkari <navyasri.tech@gmail.com>
> ---
> Changes in v2:
> - Correct the commit message to be clearer.
Doesn't apply as I think someone else made this change before you did :(
next prev parent reply other threads:[~2015-02-26 21:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-22 16:33 [PATCH v2 0/4] staging: rtl8192u: Fix warnings in ieee80211_crypt.c Navya Sri Nizamkari
2015-02-22 16:36 ` [PATCH v2 1/4] staging: rtl8192u: Convert from printk into netdev_dbg or pr_dbg Navya Sri Nizamkari
2015-02-26 21:43 ` Greg KH [this message]
2015-02-22 16:41 ` [PATCH v2 2/4] staging: rtl8192u: Remove unnecessary comment Navya Sri Nizamkari
2015-02-22 16:42 ` [PATCH v2 3/4] staging: rtl8192u: Replace asm header files with linux ones Navya Sri Nizamkari
2015-02-26 21:44 ` [Outreachy kernel] " Greg KH
2015-02-22 16:43 ` [PATCH v2 4/4] staging: rtl8192u: Fix quoted string split across lines Navya Sri Nizamkari
2015-02-26 21:44 ` [Outreachy kernel] " Greg KH
2015-02-27 15:16 ` Navya Sri Nizamkari
2015-02-27 15:25 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150226214349.GA6995@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=navyasri.tech@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.