All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Navya Sri Nizamkari <navyasri.tech@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH v4 1/4] staging: rtl8192u: Convert from printk into netdev_dbg or pr_debug
Date: Thu, 26 Feb 2015 13:47:26 -0800	[thread overview]
Message-ID: <20150226214726.GA28846@kroah.com> (raw)
In-Reply-To: <98deaa0c6c3f0623fa6a0c1479d3d3f69ff4884c.1424934230.git.navyasri.tech@gmail.com>

On Thu, Feb 26, 2015 at 12:43:43PM +0530, Navya Sri Nizamkari wrote:
> As this is a network driver file, convert printk(KERN_DEBUG.. ) to
> netdev_dbg if the calling function has arguments to support it else
> to pr_debug , to fix the checkpatch.pl warning:
> 
> WARNING: Prefer netdev_dbg(netdev, ... then dev_dbg(dev, ... then
> pr_debug(...  to printk(KERN_DEBUG ...
> 
> Signed-off-by: Navya Sri Nizamkari <navyasri.tech@gmail.com>
> ---
> Changes in v4:
>     - Changed code indentation.
> 
> Changes in v3:
>     - Change pr_dbg to pr_debug as it gives the following warning:
>       implicit declaration of function ‘pr_dbg’and change 
>       subject name to reflect the change.
> 
> Changes in v2:
>     - Correct the commit message to be clearer.
> 
>  drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
> index 5533221..eb89321 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
> @@ -66,8 +66,8 @@ void ieee80211_crypt_deinit_handler(unsigned long data)
>  	spin_lock_irqsave(&ieee->lock, flags);
>  	ieee80211_crypt_deinit_entries(ieee, 0);
>  	if (!list_empty(&ieee->crypt_deinit_list)) {
> -		printk(KERN_DEBUG "%s: entries remaining in delayed crypt "
> -		       "deletion list\n", ieee->dev->name);
> +		netdev_dbg(ieee->dev, "entries remaining in delayed crypt "
> +		       "deletion list\n");

This patch doesn't apply anymore to my tree :(


  reply	other threads:[~2015-02-26 21:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-26  7:08 [PATCH v4 0/4] staging: rtl8192u: Fix warnings in ieee80211_crypt.c Navya Sri Nizamkari
2015-02-26  7:13 ` [PATCH v4 1/4] staging: rtl8192u: Convert from printk into netdev_dbg or pr_debug Navya Sri Nizamkari
2015-02-26 21:47   ` Greg KH [this message]
2015-02-26  7:19 ` [PATCH v4 2/4] staging: rtl8192u: Remove unnecessary comment Navya Sri Nizamkari
2015-02-26  7:21 ` [PATCH v4 3/4] staging: rtl8192u: Replace asm header files with linux ones Navya Sri Nizamkari
2015-02-26  7:24 ` [PATCH v4 4/4] staging: rtl8192u: Fix quoted string split across lines Navya Sri Nizamkari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150226214726.GA28846@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=navyasri.tech@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.