[PATCH] Staging: rtl8712: Remove unused Macro

[PATCH] Staging: rtl8712: Remove unused Macro

[Katie Dunne]

Removes SetFrameType Macro because its not used elsewhere

Signed-off-by: Katie Dunne <kdunne@mail.ccsf.edu>
---
 drivers/staging/rtl8712/wifi.h | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/staging/rtl8712/wifi.h b/drivers/staging/rtl8712/wifi.h
index 5ba7e71..356059b 100644
--- a/drivers/staging/rtl8712/wifi.h
+++ b/drivers/staging/rtl8712/wifi.h
@@ -246,13 +246,6 @@ enum WIFI_REG_DOMAIN {
 #define GetFrameType(pbuf)	(le16_to_cpu(*(unsigned short *)(pbuf)) & \
 				(BIT(3) | BIT(2)))
 
-#define SetFrameType(pbuf, type)	\
-	do {	\
-		*(unsigned short *)(pbuf) &= cpu_to_le16(~(BIT(3) | \
-		BIT(2))); \
-		*(unsigned short *)(pbuf) |= cpu_to_le16(type); \
-	} while (0)
-
 #define GetFrameSubType(pbuf)	(cpu_to_le16(*(unsigned short *)(pbuf)) & \
 				(BIT(7) | BIT(6) | BIT(5) | BIT(4) | BIT(3) | \
 				BIT(2)))
-- 
1.9.1

Re: [Outreachy kernel] [PATCH] Staging: rtl8712: Remove unused Macro

[Julia Lawall]

On Tue, 24 Feb 2015, Katie Dunne wrote:

> Removes SetFrameType Macro because its not used elsewhere
>
> Signed-off-by: Katie Dunne <kdunne@mail.ccsf.edu>
> ---
>  drivers/staging/rtl8712/wifi.h | 7 -------
>  1 file changed, 7 deletions(-)
>
> diff --git a/drivers/staging/rtl8712/wifi.h b/drivers/staging/rtl8712/wifi.h
> index 5ba7e71..356059b 100644
> --- a/drivers/staging/rtl8712/wifi.h
> +++ b/drivers/staging/rtl8712/wifi.h
> @@ -246,13 +246,6 @@ enum WIFI_REG_DOMAIN {
>  #define GetFrameType(pbuf)	(le16_to_cpu(*(unsigned short *)(pbuf)) & \
>  				(BIT(3) | BIT(2)))
>
> -#define SetFrameType(pbuf, type)	\
> -	do {	\
> -		*(unsigned short *)(pbuf) &= cpu_to_le16(~(BIT(3) | \
> -		BIT(2))); \
> -		*(unsigned short *)(pbuf) |= cpu_to_le16(type); \
> -	} while (0)
> -
>  #define GetFrameSubType(pbuf)	(cpu_to_le16(*(unsigned short *)(pbuf)) & \
>  				(BIT(7) | BIT(6) | BIT(5) | BIT(4) | BIT(3) | \
>  				BIT(2)))

Maybe check on some of the other macros nearby?

julia


> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20150224162637.GA9677%40katie-Inspiron-5748.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [Outreachy kernel] [PATCH] Staging: rtl8712: Remove unused Macro

[Daniel Baluta]

On Tue, Feb 24, 2015 at 6:26 PM, Katie Dunne <kdunne@mail.ccsf.edu> wrote:
> Removes SetFrameType Macro because its not used elsewhere
>
> Signed-off-by: Katie Dunne <kdunne@mail.ccsf.edu>
> ---
>  drivers/staging/rtl8712/wifi.h | 7 -------
>  1 file changed, 7 deletions(-)
>
> diff --git a/drivers/staging/rtl8712/wifi.h b/drivers/staging/rtl8712/wifi.h
> index 5ba7e71..356059b 100644
> --- a/drivers/staging/rtl8712/wifi.h
> +++ b/drivers/staging/rtl8712/wifi.h
> @@ -246,13 +246,6 @@ enum WIFI_REG_DOMAIN {
>  #define GetFrameType(pbuf)     (le16_to_cpu(*(unsigned short *)(pbuf)) & \
>                                 (BIT(3) | BIT(2)))
>
> -#define SetFrameType(pbuf, type)       \
> -       do {    \
> -               *(unsigned short *)(pbuf) &= cpu_to_le16(~(BIT(3) | \
> -               BIT(2))); \
> -               *(unsigned short *)(pbuf) |= cpu_to_le16(type); \
> -       } while (0)
> -
>  #define GetFrameSubType(pbuf)  (cpu_to_le16(*(unsigned short *)(pbuf)) & \
>                                 (BIT(7) | BIT(6) | BIT(5) | BIT(4) | BIT(3) | \
>                                 BIT(2)))

Also,

$ ack-grep SetFrameType
drivers/staging/rtl8188eu/include/wifi.h
314:#define SetFrameType(pbuf, type) \

drivers/staging/rtl8712/wifi.h
249:#define SetFrameType(pbuf, type) \

Daniel.

Re: [Outreachy kernel] [PATCH] Staging: rtl8712: Remove unused Macro

[Greg KH]

On Tue, Feb 24, 2015 at 08:26:37AM -0800, Katie Dunne wrote:
> Removes SetFrameType Macro because its not used elsewhere
> 
> Signed-off-by: Katie Dunne <kdunne@mail.ccsf.edu>
> ---
>  drivers/staging/rtl8712/wifi.h | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/drivers/staging/rtl8712/wifi.h b/drivers/staging/rtl8712/wifi.h
> index 5ba7e71..356059b 100644
> --- a/drivers/staging/rtl8712/wifi.h
> +++ b/drivers/staging/rtl8712/wifi.h
> @@ -246,13 +246,6 @@ enum WIFI_REG_DOMAIN {
>  #define GetFrameType(pbuf)	(le16_to_cpu(*(unsigned short *)(pbuf)) & \
>  				(BIT(3) | BIT(2)))
>  
> -#define SetFrameType(pbuf, type)	\
> -	do {	\
> -		*(unsigned short *)(pbuf) &= cpu_to_le16(~(BIT(3) | \
> -		BIT(2))); \
> -		*(unsigned short *)(pbuf) |= cpu_to_le16(type); \
> -	} while (0)
> -
>  #define GetFrameSubType(pbuf)	(cpu_to_le16(*(unsigned short *)(pbuf)) & \
>  				(BIT(7) | BIT(6) | BIT(5) | BIT(4) | BIT(3) | \
>  				BIT(2)))

No longer applies to my tree, sorry :(