All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Gulsah Kose <gulsah.1004@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH 2/7] staging: ft1000: ft1000-pcmcia: Used "linux" instead of "asm".
Date: Thu, 26 Feb 2015 15:13:56 -0800	[thread overview]
Message-ID: <20150226231356.GB402@kroah.com> (raw)
In-Reply-To: <05bf8f78a414fb666c44db4620fac95a1e1e925b.1424569663.git.gulsah.1004@gmail.com>

On Sun, Feb 22, 2015 at 03:51:58AM +0200, Gulsah Kose wrote:
> Used "linux" instead of "asm" and removed following checkpatch.pl warning:
> WARNING: Use #include <linux/io.h> instead of <asm/io.h>
> 
> Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
> ---
>  drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c
> index 017c3b9..5358dac 100644
> --- a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c
> +++ b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c
> @@ -28,7 +28,7 @@
>  #include <linux/timer.h>
>  #include <linux/interrupt.h>
>  #include <linux/in.h>
> -#include <asm/io.h>
> +#include <linux/io.h>
>  #include <asm/bitops.h>
>  
>  #include <linux/netdevice.h>


Please just fix both asm/ include file issues in the same patch, not in
2 different patches.

thanks,

greg k-h


  reply	other threads:[~2015-02-26 23:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-22  1:51 [PATCH 0/7] Removed some checkpatch.pl warnings Gulsah Kose
2015-02-22  1:51 ` [PATCH 1/7] staging: arch: alpha: boot: Combined seperated strings Gulsah Kose
2015-02-26 23:13   ` [Outreachy kernel] " Greg KH
2015-02-22  1:51 ` [PATCH 2/7] staging: ft1000: ft1000-pcmcia: Used "linux" instead of "asm" Gulsah Kose
2015-02-26 23:13   ` Greg KH [this message]
2015-02-22  1:51 ` [PATCH 3/7] " Gulsah Kose
2015-02-22  1:52 ` [PATCH 4/7] staging: ft1000: ft1000-pcmcia: Removed all useless "else" Gulsah Kose
2015-02-22  1:52 ` [PATCH 5/7] staging: ft1000: ft1000-pcmcia: Deleted unnecessary braces Gulsah Kose
2015-02-22  1:52 ` [PATCH 6/7] staging: ft1000: ft1000-pcmcia: Removed unnecessary parentheses Gulsah Kose
2015-02-22  1:52 ` [PATCH 7/7] staging: ft1000: ft1000-pcmcia: Added missing blank line Gulsah Kose

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150226231356.GB402@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=gulsah.1004@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.