From: Greg KH <gregkh@linuxfoundation.org>
To: aybuke ozdemir <aybuke.147@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH v2] Staging: unisys: Change char * array type as static const
Date: Thu, 26 Feb 2015 15:18:22 -0800 [thread overview]
Message-ID: <20150226231822.GA10936@kroah.com> (raw)
In-Reply-To: <1424817582-9438-1-git-send-email-aybuke.147@gmail.com>
On Wed, Feb 25, 2015 at 12:39:42AM +0200, aybuke ozdemir wrote:
> This patch fixes "char * array declaration might be better as static
> const" checkpatch.pl warning in visorchipset_main.c
> After this exchange that can be accessed pointer, without object
> derived from the instance but just just read operation can be done in
> pointer.
>
> Signed-off-by: aybuke ozdemir <aybuke.147@gmail.com>
> ---
> Changes since v1:
> * Used "static const char *const" instead of "static char const"
> ---
> drivers/staging/unisys/visorchipset/visorchipset_main.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Please _always_ compile your changes, this one broke the build so badly
that is is obvious you didn't even try to build it :(
prev parent reply other threads:[~2015-02-26 23:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-24 22:39 [PATCH v2] Staging: unisys: Change char * array type as static const aybuke ozdemir
2015-02-26 23:18 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150226231822.GA10936@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=aybuke.147@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.