From: Bjorn Helgaas <bhelgaas@google.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Arnd Bergmann <arnd@arndb.de>,
Joachim Nilsson <troglobit@gmail.com>,
linux-pci <linux-pci@vger.kernel.org>,
Rob Herring <robh@kernel.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Subject: Re: [PATCH] pci-versatile.c: Update for API change in list_for_each_entry()
Date: Thu, 26 Feb 2015 17:35:07 -0600 [thread overview]
Message-ID: <20150226233507.GD25765@google.com> (raw)
In-Reply-To: <1908959.51iYpqoucA@vostro.rjw.lan>
On Thu, Feb 26, 2015 at 04:45:15PM +0100, Rafael J. Wysocki wrote:
> On Thursday, February 26, 2015 08:41:37 AM Linus Walleij wrote:
> > On Wed, Feb 25, 2015 at 4:15 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> >
> > > From: Joachim Nilsson <troglobit@gmail.com>
> > >
> > > In Linux 4.0-rc1 ARM Versatile PCI build fails to build due to what
> > > appears to be an API update. This patch is a very simple correction,
> > > merely posted as a heads-up to the maintainers. Hopefully a better
> > > fix can be forwarded to Linus.
> > >
> > > [arnd: the patch actually looks correct, so let's take this version]
> > >
> > > Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
> > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > > ---
> > >
> > > Joachim reported the bug, and I independently found the same problem.
> > > The patch he sent to the list did not apply for me for an unknown reason,
> > > but I fixed it up and forward it now to the right list of recipients.
> >
> > Acked-by: Linus Walleij <linus.walleij@linaro.org>
>
> Do I need to take this one? Bjorn?
Yeah, if you don't mind, why don't you take it, Rafael. I think it was
introduced by 872912352c5b ("Merge tag 'pm+acpi-3.20-rc1' of
git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm"). I don't
really understand that commit, but it looks like this part of it is the
problem:
- list_for_each_entry(win, res, list) {
++ resource_list_for_each_entry(win, res, list) {
If you do, would you mind updating the subject line and adding these acks?
PCI: versatile: Update for list_for_each_entry() API change
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Bjorn Helgaas <bhelgaas@google.com>
Bjorn
next prev parent reply other threads:[~2015-02-26 23:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-25 15:15 [PATCH] pci-versatile.c: Update for API change in list_for_each_entry() Arnd Bergmann
2015-02-26 7:41 ` Linus Walleij
2015-02-26 15:45 ` Rafael J. Wysocki
2015-02-26 23:35 ` Bjorn Helgaas [this message]
2015-02-28 0:11 ` Rafael J. Wysocki
-- strict thread matches above, loose matches on Subject: below --
2015-02-24 8:26 Troglobit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150226233507.GD25765@google.com \
--to=bhelgaas@google.com \
--cc=arnd@arndb.de \
--cc=linus.walleij@linaro.org \
--cc=linux-pci@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rjw@rjwysocki.net \
--cc=robh@kernel.org \
--cc=troglobit@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.