* [PATCH] pci-versatile.c: Update for API change in list_for_each_entry()
@ 2015-02-25 15:15 Arnd Bergmann
2015-02-26 7:41 ` Linus Walleij
0 siblings, 1 reply; 6+ messages in thread
From: Arnd Bergmann @ 2015-02-25 15:15 UTC (permalink / raw)
To: Bjorn Helgaas
Cc: Joachim Nilsson, linux-pci, Rob Herring, Linus Walleij,
Rafael J. Wysocki
From: Joachim Nilsson <troglobit@gmail.com>
In Linux 4.0-rc1 ARM Versatile PCI build fails to build due to what
appears to be an API update. This patch is a very simple correction,
merely posted as a heads-up to the maintainers. Hopefully a better
fix can be forwarded to Linus.
[arnd: the patch actually looks correct, so let's take this version]
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
Joachim reported the bug, and I independently found the same problem.
The patch he sent to the list did not apply for me for an unknown reason,
but I fixed it up and forward it now to the right list of recipients.
diff --git a/drivers/pci/host/pci-versatile.c b/drivers/pci/host/pci-versatile.c
index 1ec694a52379..464bf492ee2a 100644
--- a/drivers/pci/host/pci-versatile.c
+++ b/drivers/pci/host/pci-versatile.c
@@ -80,7 +80,7 @@ static int versatile_pci_parse_request_of_pci_ranges(struct device *dev,
if (err)
return err;
- resource_list_for_each_entry(win, res, list) {
+ resource_list_for_each_entry(win, res) {
struct resource *parent, *res = win->res;
switch (resource_type(res)) {
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] pci-versatile.c: Update for API change in list_for_each_entry()
2015-02-25 15:15 [PATCH] pci-versatile.c: Update for API change in list_for_each_entry() Arnd Bergmann
@ 2015-02-26 7:41 ` Linus Walleij
2015-02-26 15:45 ` Rafael J. Wysocki
0 siblings, 1 reply; 6+ messages in thread
From: Linus Walleij @ 2015-02-26 7:41 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Bjorn Helgaas, Joachim Nilsson, linux-pci, Rob Herring,
Rafael J. Wysocki
On Wed, Feb 25, 2015 at 4:15 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> From: Joachim Nilsson <troglobit@gmail.com>
>
> In Linux 4.0-rc1 ARM Versatile PCI build fails to build due to what
> appears to be an API update. This patch is a very simple correction,
> merely posted as a heads-up to the maintainers. Hopefully a better
> fix can be forwarded to Linus.
>
> [arnd: the patch actually looks correct, so let's take this version]
>
> Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>
> Joachim reported the bug, and I independently found the same problem.
> The patch he sent to the list did not apply for me for an unknown reason,
> but I fixed it up and forward it now to the right list of recipients.
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] pci-versatile.c: Update for API change in list_for_each_entry()
2015-02-26 7:41 ` Linus Walleij
@ 2015-02-26 15:45 ` Rafael J. Wysocki
2015-02-26 23:35 ` Bjorn Helgaas
0 siblings, 1 reply; 6+ messages in thread
From: Rafael J. Wysocki @ 2015-02-26 15:45 UTC (permalink / raw)
To: Linus Walleij, Bjorn Helgaas
Cc: Arnd Bergmann, Joachim Nilsson, linux-pci, Rob Herring,
Rafael J. Wysocki
On Thursday, February 26, 2015 08:41:37 AM Linus Walleij wrote:
> On Wed, Feb 25, 2015 at 4:15 PM, Arnd Bergmann <arnd@arndb.de> wrote:
>
> > From: Joachim Nilsson <troglobit@gmail.com>
> >
> > In Linux 4.0-rc1 ARM Versatile PCI build fails to build due to what
> > appears to be an API update. This patch is a very simple correction,
> > merely posted as a heads-up to the maintainers. Hopefully a better
> > fix can be forwarded to Linus.
> >
> > [arnd: the patch actually looks correct, so let's take this version]
> >
> > Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > ---
> >
> > Joachim reported the bug, and I independently found the same problem.
> > The patch he sent to the list did not apply for me for an unknown reason,
> > but I fixed it up and forward it now to the right list of recipients.
>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
Do I need to take this one? Bjorn?
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] pci-versatile.c: Update for API change in list_for_each_entry()
2015-02-26 15:45 ` Rafael J. Wysocki
@ 2015-02-26 23:35 ` Bjorn Helgaas
2015-02-28 0:11 ` Rafael J. Wysocki
0 siblings, 1 reply; 6+ messages in thread
From: Bjorn Helgaas @ 2015-02-26 23:35 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Linus Walleij, Arnd Bergmann, Joachim Nilsson, linux-pci,
Rob Herring, Rafael J. Wysocki
On Thu, Feb 26, 2015 at 04:45:15PM +0100, Rafael J. Wysocki wrote:
> On Thursday, February 26, 2015 08:41:37 AM Linus Walleij wrote:
> > On Wed, Feb 25, 2015 at 4:15 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> >
> > > From: Joachim Nilsson <troglobit@gmail.com>
> > >
> > > In Linux 4.0-rc1 ARM Versatile PCI build fails to build due to what
> > > appears to be an API update. This patch is a very simple correction,
> > > merely posted as a heads-up to the maintainers. Hopefully a better
> > > fix can be forwarded to Linus.
> > >
> > > [arnd: the patch actually looks correct, so let's take this version]
> > >
> > > Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
> > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > > ---
> > >
> > > Joachim reported the bug, and I independently found the same problem.
> > > The patch he sent to the list did not apply for me for an unknown reason,
> > > but I fixed it up and forward it now to the right list of recipients.
> >
> > Acked-by: Linus Walleij <linus.walleij@linaro.org>
>
> Do I need to take this one? Bjorn?
Yeah, if you don't mind, why don't you take it, Rafael. I think it was
introduced by 872912352c5b ("Merge tag 'pm+acpi-3.20-rc1' of
git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm"). I don't
really understand that commit, but it looks like this part of it is the
problem:
- list_for_each_entry(win, res, list) {
++ resource_list_for_each_entry(win, res, list) {
If you do, would you mind updating the subject line and adding these acks?
PCI: versatile: Update for list_for_each_entry() API change
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Bjorn Helgaas <bhelgaas@google.com>
Bjorn
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] pci-versatile.c: Update for API change in list_for_each_entry()
2015-02-26 23:35 ` Bjorn Helgaas
@ 2015-02-28 0:11 ` Rafael J. Wysocki
0 siblings, 0 replies; 6+ messages in thread
From: Rafael J. Wysocki @ 2015-02-28 0:11 UTC (permalink / raw)
To: Bjorn Helgaas
Cc: Linus Walleij, Arnd Bergmann, Joachim Nilsson, linux-pci,
Rob Herring, Rafael J. Wysocki
On Thursday, February 26, 2015 05:35:07 PM Bjorn Helgaas wrote:
> On Thu, Feb 26, 2015 at 04:45:15PM +0100, Rafael J. Wysocki wrote:
> > On Thursday, February 26, 2015 08:41:37 AM Linus Walleij wrote:
> > > On Wed, Feb 25, 2015 at 4:15 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> > >
> > > > From: Joachim Nilsson <troglobit@gmail.com>
> > > >
> > > > In Linux 4.0-rc1 ARM Versatile PCI build fails to build due to what
> > > > appears to be an API update. This patch is a very simple correction,
> > > > merely posted as a heads-up to the maintainers. Hopefully a better
> > > > fix can be forwarded to Linus.
> > > >
> > > > [arnd: the patch actually looks correct, so let's take this version]
> > > >
> > > > Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
> > > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > > > ---
> > > >
> > > > Joachim reported the bug, and I independently found the same problem.
> > > > The patch he sent to the list did not apply for me for an unknown reason,
> > > > but I fixed it up and forward it now to the right list of recipients.
> > >
> > > Acked-by: Linus Walleij <linus.walleij@linaro.org>
> >
> > Do I need to take this one? Bjorn?
>
> Yeah, if you don't mind, why don't you take it, Rafael. I think it was
> introduced by 872912352c5b ("Merge tag 'pm+acpi-3.20-rc1' of
> git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm"). I don't
> really understand that commit, but it looks like this part of it is the
> problem:
>
> - list_for_each_entry(win, res, list) {
> ++ resource_list_for_each_entry(win, res, list) {
>
> If you do, would you mind updating the subject line and adding these acks?
>
> PCI: versatile: Update for list_for_each_entry() API change
>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
> Acked-by: Bjorn Helgaas <bhelgaas@google.com>
Done.
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] pci-versatile.c: Update for API change in list_for_each_entry()
@ 2015-02-24 8:26 Troglobit
0 siblings, 0 replies; 6+ messages in thread
From: Troglobit @ 2015-02-24 8:26 UTC (permalink / raw)
To: linux-arm-kernel
In Linux 4.0-rc1 ARM Versatile PCI build fails to build due to what
appears to be an API update. This patch is a very simple correction,
merely posted as a heads-up to the maintainers. Hopefully a better
fix can be forwarded to Linus.
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
---
drivers/pci/host/pci-versatile.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/host/pci-versatile.c b/drivers/pci/host/pci-versatile.c
index 1ec694a..464bf49 100644
--- a/drivers/pci/host/pci-versatile.c
+++ b/drivers/pci/host/pci-versatile.c
@@ -80,7 +80,7 @@ static int versatile_pci_parse_request_of_pci_ranges(struct device *dev,
if (err)
return err;
- resource_list_for_each_entry(win, res, list) {
+ resource_list_for_each_entry(win, res) {
struct resource *parent, *res = win->res;
switch (resource_type(res)) {
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-02-27 23:48 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-25 15:15 [PATCH] pci-versatile.c: Update for API change in list_for_each_entry() Arnd Bergmann
2015-02-26 7:41 ` Linus Walleij
2015-02-26 15:45 ` Rafael J. Wysocki
2015-02-26 23:35 ` Bjorn Helgaas
2015-02-28 0:11 ` Rafael J. Wysocki
-- strict thread matches above, loose matches on Subject: below --
2015-02-24 8:26 Troglobit
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.