All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Corbet <corbet@lwn.net>
To: Valentin Rothberg <Valentin.Rothberg@lip6.fr>
Cc: bhelgaas@google.com, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] MSI-HOWTO.txt: remove reference on IRQF_DISABLED
Date: Fri, 27 Feb 2015 15:17:07 -0700	[thread overview]
Message-ID: <20150227151707.3bf64000@lwn.net> (raw)
In-Reply-To: <1425038116-19227-1-git-send-email-Valentin.Rothberg@lip6.fr>

On Fri, 27 Feb 2015 12:55:16 +0100
Valentin Rothberg <Valentin.Rothberg@lip6.fr> wrote:

> The IRQF_DISABLED is a NOOP and scheduled to be removed.  According to
> Ingo Molnar (e58aa3d2d0cc01ad8d6f7f640a0670433f794922) running IRQ
> handlers with interrupts enabled can cause stack overflows when the
> interrupt line of the issuing device is still active.
> 
> This patch removes IRQF_DISABLED from this documentation.  It was
> mentioned to be a solution to avoid deadlocks when a device uses
> multiple interrupts.  As the flag is a NOOP this solution does not work
> anymore.

Seems good, applied to the docs tree.  I reworked the commit ID in the
changelog into the standard form (adding the one-line description),
though.

Thanks,

jon

  reply	other threads:[~2015-02-27 22:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-27 11:55 [PATCH v2] MSI-HOWTO.txt: remove reference on IRQF_DISABLED Valentin Rothberg
2015-02-27 22:17 ` Jonathan Corbet [this message]
2015-02-27 22:22   ` Valentin Rothberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150227151707.3bf64000@lwn.net \
    --to=corbet@lwn.net \
    --cc=Valentin.Rothberg@lip6.fr \
    --cc=bhelgaas@google.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.