Re: [Outreachy kernel] [PATCH 5/5] Staging: lustre: lustre: ldlm: Concatenate strings into single string

[Haneen Mohammed <hamohammed.sa@gmail.com>]

On Sat, Feb 28, 2015 at 02:56:10PM -0500, Julia Lawall wrote:
> On Sat, 28 Feb 2015, Haneen Mohammed wrote:
> 
> > This patch concatenate two consecutive strings into one, addressing checkpatch.pl warning:
> >  "Consecutive strings are generally better as a single string"
> >
> > Signed-off-by: Haneen Mohammed <hamohammed.sa@gmail.com>
> > ---
> >  drivers/staging/lustre/lustre/ldlm/ldlm_pool.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/lustre/lustre/ldlm/ldlm_pool.c b/drivers/staging/lustre/lustre/ldlm/ldlm_pool.c
> > index bfdb2b3..0d65d80 100644
> > --- a/drivers/staging/lustre/lustre/ldlm/ldlm_pool.c
> > +++ b/drivers/staging/lustre/lustre/ldlm/ldlm_pool.c
> > @@ -688,8 +688,8 @@ static int lprocfs_pool_state_seq_show(struct seq_file *m, void *unused)
> >  			      "  GP:  %d\n",
> >  			      grant_step, grant_plan);
> >  	}
> > -	seq_printf(m, "  GR:  %d\n" "  CR:  %d\n" "  GS:  %d\n"
> > -		      "  G:   %d\n" "  L:   %d\n",
> > +	seq_printf(m, "  GR:  %d\n  CR:  %d\n  GS:  %d\n"
> > +		      "  G:   %d\n  L:   %d\n",
> 
> The two lines are consecutive strings also.  Checkpatch should have given
> you a warning on your result.
> 
> julia
> 

Strangely it didn't so I thought that was special case. Should I
combine them all into one?

Thanks,
Haneen
> >  		      grant_rate, cancel_rate, grant_speed,
> >  		      granted, limit);
> >
> > --
> > 1.9.1
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1425152027-31192-1-git-send-email-hamohammed.sa%40gmail.com.
> > For more options, visit https://groups.google.com/d/optout.
> >