From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753584AbbCAQLl (ORCPT <rfc822;w@1wt.eu>);
	Sun, 1 Mar 2015 11:11:41 -0500
Received: from mail-wi0-f170.google.com ([209.85.212.170]:34857 "EHLO
	mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751985AbbCAQLi (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 1 Mar 2015 11:11:38 -0500
Date: Sun, 1 Mar 2015 17:11:33 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>, linux-kernel@vger.kernel.org,
        Adrian Hunter <adrian.hunter@intel.com>,
        Andi Kleen <ak@linux.intel.com>, Borislav Petkov <bp@suse.de>,
        David Ahern <david.ahern@oracle.com>, He Kuang <hekuang@huawei.com>,
        Hemant Kumar <hemant@linux.vnet.ibm.com>,
        Kan Liang <kan.liang@intel.com>,
        Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
        Namhyung Kim <namhyung@kernel.org>, Naohiro Aota <naota@elisp.net>,
        Paul Mackerras <paulus@samba.org>,
        Peter Zijlstra <peterz@infradead.org>, Wang Nan <wangnan0@huawei.com>,
        Yunlong Song <yunlong.song@huawei.com>,
        Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: Re: [PATCH] perf tools: Fix pthread_attr_setaffinity_np() feature
 detection on Ubuntu systems
Message-ID: <20150301161132.GA19425@gmail.com>
References: <1425064989-26440-1-git-send-email-acme@kernel.org>
 <20150228074746.GA14064@gmail.com>
 <20150228225751.GC13177@krava.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150228225751.GC13177@krava.redhat.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Jiri Olsa <jolsa@redhat.com> wrote:

> agreed, sry about that.. I'll try to clean it up while moving 
> features detection into tools/ as you suggested before

That would be nice!

> > --- a/tools/perf/config/feature-checks/test-pthread-attr-setaffinity-np.c
> > +++ b/tools/perf/config/feature-checks/test-pthread-attr-setaffinity-np.c
> > @@ -5,10 +5,12 @@ int main(void)
> >  {
> >  	int ret = 0;
> >  	pthread_attr_t thread_attr;
> > +	cpu_set_t cpu_mask;
> >  
> >  	pthread_attr_init(&thread_attr);
> > -	/* don't care abt exact args, just the API itself in libpthread */
> > -	ret = pthread_attr_setaffinity_np(&thread_attr, 0, NULL);
> > +	CPU_ZERO(&cpu_mask);
> > +
> > +	ret = pthread_attr_setaffinity_np(&thread_attr, sizeof(cpu_mask), &cpu_mask);
> 
> I think Arnaldo got this one covered in perf/urgent already, but I 
> might have missed something..

Ok, I'll wait for his set of fixes.

Thanks,

	Ingo