From: Ingo Molnar <mingo@kernel.org>
To: hpa@zytor.com, adrian.hunter@intel.com, eranian@google.com,
linux-kernel@vger.kernel.org, tglx@linutronix.de,
jolsa@redhat.com, acme@redhat.com
Cc: linux-tip-commits@vger.kernel.org
Subject: Re: [tip:perf/urgent] perf tools: Fix pthread_attr_setaffinity_np build error
Date: Sun, 1 Mar 2015 17:52:36 +0100 [thread overview]
Message-ID: <20150301165235.GA24700@gmail.com> (raw)
In-Reply-To: <tip-95a09cfa3cdf94231ce511f1697754482b918d39@git.kernel.org>
* tip-bot for Adrian Hunter <tipbot@zytor.com> wrote:
> --- a/tools/perf/config/feature-checks/test-pthread-attr-setaffinity-np.c
> +++ b/tools/perf/config/feature-checks/test-pthread-attr-setaffinity-np.c
> @@ -5,10 +5,11 @@ int main(void)
> {
> int ret = 0;
> pthread_attr_t thread_attr;
> + cpu_set_t cs;
>
> pthread_attr_init(&thread_attr);
> /* don't care abt exact args, just the API itself in libpthread */
> - ret = pthread_attr_setaffinity_np(&thread_attr, 0, NULL);
> + ret = pthread_attr_setaffinity_np(&thread_attr, sizeof(cs), &cs);
So I'm splitting hairs, as we never run these testcases, but I think a
CPU_ZERO(&cs) is needed, as 'cs' might be uninitialized.
Thanks,
Ingo
next prev parent reply other threads:[~2015-03-01 16:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-24 10:46 [PATCH] perf tools: Fix pthread_attr_setaffinity_np build error Adrian Hunter
2015-02-24 13:32 ` Josh Boyer
2015-02-24 13:52 ` Adrian Hunter
2015-02-24 14:31 ` Josh Boyer
2015-02-25 6:50 ` Adrian Hunter
2015-03-01 16:50 ` [tip:perf/urgent] " tip-bot for Adrian Hunter
2015-03-01 16:52 ` Ingo Molnar [this message]
2015-03-02 7:59 ` [PATCH] perf tools: Initialize cpu set in pthread_attr_setaffinity_np feature test Adrian Hunter
2015-03-03 6:26 ` [tip:perf/core] " tip-bot for Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150301165235.GA24700@gmail.com \
--to=mingo@kernel.org \
--cc=acme@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=eranian@google.com \
--cc=hpa@zytor.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.