All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Zhu Guihua <zhugh.fnst@cn.fujitsu.com>
Cc: hutao@cn.fujitsu.com, qemu-devel@nongnu.org,
	tangchen@cn.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com,
	pbonzini@redhat.com, guz.fnst@cn.fujitsu.com,
	imammedo@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3 08/10] qdev: make qdev_get_hotplug_handler() non-static
Date: Sun, 1 Mar 2015 18:10:29 +0100	[thread overview]
Message-ID: <20150301171029.GA8233@redhat.com> (raw)
In-Reply-To: <56ec427cdaf204091bae2df63b63a7baba88ba9b.1424912878.git.zhugh.fnst@cn.fujitsu.com>

On Thu, Feb 26, 2015 at 09:16:50AM +0800, Zhu Guihua wrote:
> Memory hotplug code will use qdev_get_hotplug_handler().
> 
> Signed-off-by: Zhu Guihua <zhugh.fnst@cn.fujitsu.com>

don't send patches like this pls.
Just merge this with code that uses it.

> ---
>  hw/core/qdev.c         | 2 +-
>  include/hw/qdev-core.h | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/hw/core/qdev.c b/hw/core/qdev.c
> index 2eacac0..2f3d1df 100644
> --- a/hw/core/qdev.c
> +++ b/hw/core/qdev.c
> @@ -273,7 +273,7 @@ void qdev_set_legacy_instance_id(DeviceState *dev, int alias_id,
>      dev->alias_required_for_version = required_for_version;
>  }
>  
> -static HotplugHandler *qdev_get_hotplug_handler(DeviceState *dev)
> +HotplugHandler *qdev_get_hotplug_handler(DeviceState *dev)
>  {
>      HotplugHandler *hotplug_ctrl = NULL;
>  
> diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h
> index 15a226f..03d6239 100644
> --- a/include/hw/qdev-core.h
> +++ b/include/hw/qdev-core.h
> @@ -266,6 +266,7 @@ int qdev_init(DeviceState *dev) QEMU_WARN_UNUSED_RESULT;
>  void qdev_init_nofail(DeviceState *dev);
>  void qdev_set_legacy_instance_id(DeviceState *dev, int alias_id,
>                                   int required_for_version);
> +HotplugHandler *qdev_get_hotplug_handler(DeviceState *dev);
>  void qdev_unplug(DeviceState *dev, Error **errp);
>  void qdev_simple_device_unplug_cb(HotplugHandler *hotplug_dev,
>                                    DeviceState *dev, Error **errp);
> -- 
> 1.9.3

  reply	other threads:[~2015-03-01 17:10 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-26  1:16 [Qemu-devel] [PATCH v3 00/10] QEMU memory hot unplug support Zhu Guihua
2015-02-26  1:16 ` [Qemu-devel] [PATCH v3 01/10] acpi, mem-hotplug: Use PC_DIMM_SLOT_PROP in acpi_memory_plug_cb() Zhu Guihua
2015-03-01 17:32   ` Michael S. Tsirkin
2015-02-26  1:16 ` [Qemu-devel] [PATCH v3 02/10] acpi, mem-hotplug: Add acpi_memory_slot_status() to get MemStatus Zhu Guihua
2015-03-01 17:31   ` Michael S. Tsirkin
2015-03-03  2:18     ` Zhu Guihua
2015-03-03 13:43       ` Michael S. Tsirkin
2015-03-04  3:03         ` Zhu Guihua
2015-02-26  1:16 ` [Qemu-devel] [PATCH v3 03/10] acpi, mem-hotplug: Add acpi_send_gpe_event() to rise sci for memory hotplug Zhu Guihua
2015-03-01 17:29   ` Michael S. Tsirkin
2015-03-02  9:27     ` Igor Mammedov
2015-03-02  9:58       ` Michael S. Tsirkin
2015-03-04 12:16       ` Michael S. Tsirkin
2015-02-26  1:16 ` [Qemu-devel] [PATCH v3 04/10] acpi, mem-hotplug: Add unplug request cb for memory device Zhu Guihua
2015-03-01 17:25   ` Michael S. Tsirkin
2015-02-26  1:16 ` [Qemu-devel] [PATCH v3 05/10] ich9, piix4, pc-dimm: Add memory hot unplug request support Zhu Guihua
2015-02-26  1:16 ` [Qemu-devel] [PATCH v3 06/10] acpi, mem-hotplug: Add unplug cb for memory device Zhu Guihua
2015-03-01 17:21   ` Michael S. Tsirkin
2015-02-26  1:16 ` [Qemu-devel] [PATCH v3 07/10] ich9, piix4, pc-dimm: Add memory hot unplug support Zhu Guihua
2015-02-26  1:16 ` [Qemu-devel] [PATCH v3 08/10] qdev: make qdev_get_hotplug_handler() non-static Zhu Guihua
2015-03-01 17:10   ` Michael S. Tsirkin [this message]
2015-02-26  1:16 ` [Qemu-devel] [PATCH v3 09/10] ssdt-mem: add MEMORY_SLOT_EJECT_METHOD Zhu Guihua
2015-03-01 17:11   ` Michael S. Tsirkin
2015-02-26  1:16 ` [Qemu-devel] [PATCH v3 10/10] acpi: Add hardware implementation for memory hot unplug Zhu Guihua
2015-03-01 17:16   ` Michael S. Tsirkin
2015-03-01 17:35 ` [Qemu-devel] [PATCH v3 00/10] QEMU memory hot unplug support Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150301171029.GA8233@redhat.com \
    --to=mst@redhat.com \
    --cc=guz.fnst@cn.fujitsu.com \
    --cc=hutao@cn.fujitsu.com \
    --cc=imammedo@redhat.com \
    --cc=isimatu.yasuaki@jp.fujitsu.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=tangchen@cn.fujitsu.com \
    --cc=zhugh.fnst@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.