Re: [Outreachy kernel] [PATCH 2/2] Staging: rtl8712: Eliminate use of _init_timer

[Greg KH <gregkh@linuxfoundation.org>]

On Fri, Feb 27, 2015 at 11:26:22PM +0530, Vaishali Thakkar wrote:
> This patch introduces the use of API function setup_timer
> instead of driver specific function _init_timer as it is
> the preferred and standard way to setup and set the timer.
> Also, definition of function _init_timer is removed as it
> is no longer needed after this change.
> 
> This is done using Coccinelle and semantic patch used for
> this is as follows:
> 
> @@ expression x, y; identifier a, b;@@
> 
> - _init_timer (&x, y, a, b);
> + setup_timer (&x, a, (unsigned long)b);
> 
> Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
> ---
>  drivers/staging/rtl8712/mlme_linux.c      | 27 +++++++++++++--------------
>  drivers/staging/rtl8712/os_intfs.c        |  4 ++--
>  drivers/staging/rtl8712/osdep_service.h   |  9 ---------
>  drivers/staging/rtl8712/recv_linux.c      |  5 +++--
>  drivers/staging/rtl8712/rtl8712_led.c     |  3 ++-
>  drivers/staging/rtl8712/rtl871x_pwrctrl.c |  4 ++--
>  6 files changed, 22 insertions(+), 30 deletions(-)

This patch adds a bunch of compiler warnings, so I can't take it :(

Please fix up and resend, and be more careful in the future.

thanks,

greg k-h