From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753702AbbCBKUh (ORCPT <rfc822;w@1wt.eu>);
	Mon, 2 Mar 2015 05:20:37 -0500
Received: from zeniv.linux.org.uk ([195.92.253.2]:40855 "EHLO
	ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751057AbbCBKUf (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 2 Mar 2015 05:20:35 -0500
Date: Mon, 2 Mar 2015 10:20:32 +0000
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Richard Weinberger <richard.weinberger@gmail.com>
Cc: Alexander Holler <holler@ahsoftware.de>,
        USB list <linux-usb@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: gadgetfs broken since 7f7f25e8
Message-ID: <20150302102032.GP29656@ZenIV.linux.org.uk>
References: <54F41F11.1020506@ahsoftware.de>
 <CAFLxGvwbwhN7QAe-1og+=8_wg=f2WXq7wCUWvcgO8NkFZT5k=g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFLxGvwbwhN7QAe-1og+=8_wg=f2WXq7wCUWvcgO8NkFZT5k=g@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Mar 02, 2015 at 10:13:27AM +0100, Richard Weinberger wrote:
> On Mon, Mar 2, 2015 at 9:28 AM, Alexander Holler <holler@ahsoftware.de> wrote:
> > Hello.
> >
> > Commit 7f7f25e82d54870df24d415a7007fbd327da027b (introduced with 3.16) broke
> > dynamic changing of file_operations->[read|write].
> >
> > At least gadgetfs is a victim.
> >
> > Feel free to ask me off-list for a patch as I don't want to end up in
> > annoying discussions on Linux kernel lists anymore.
> >
> > Alexander Holler
> 
> CC'ing Al.

I know.  FWIW, gadgetfs is one of the very few places that tried to pull that
crap off and it had always been seriously racy.  I've posted a partial analysis
about a month ago (<20150204190645.GJ29656@ZenIV.linux.org.uk>).

If Alexander (or anybody else) has a patch that really fixes that thing,
I would certainly like to see it.  If not, I'll try to cook something,
but I'm not very familiar with that code.  I really hope that this patch
isn't "modify ->f_mode to match ->f_op change" - that's too racy.
We'll obviously need to fix the userland-visible breakage in that one,
but that's not the way to go...