From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from lists.s-osg.org ([54.187.51.154]:58727 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754591AbbCBOeI (ORCPT ); Mon, 2 Mar 2015 09:34:08 -0500 Date: Mon, 2 Mar 2015 11:34:01 -0300 From: Mauro Carvalho Chehab To: Hans Verkuil Cc: Linux Media Mailing List , Mauro Carvalho Chehab , Antti Palosaari , Matthias Schwarzott , Hans Verkuil , Rafael =?UTF-8?B?TG91cmVuw6dv?= de Lima Chehab Subject: Re: [PATCH 1/2] [media] dvbdev: use adapter arg for dvb_create_media_graph() Message-ID: <20150302113401.47208e75@recife.lan> In-Reply-To: <54F46E83.2010008@xs4all.nl> References: <54F46E83.2010008@xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Em Mon, 02 Mar 2015 15:06:59 +0100 Hans Verkuil escreveu: > Hi Mauro, > > Small nitpick: > > > extern void dvb_unregister_device (struct dvb_device *dvbdev); > > -void dvb_create_media_graph(struct media_device *mdev); > > + > > +#ifdef CONFIG_MEDIA_CONTROLLER_DVB > > +void dvb_create_media_graph(struct dvb_adapter *adap); > > +#else > > +static inline void dvb_create_media_graph(struct dvb_adapter *adap) {}; > > Unnecessary trailing ';'. > > Regards, > > Hans > Fixed, thanks! Regards, Mauro